[DiscordArchive] is there guidance on what should be created as a module vs being PR'd to the core repo?
[DiscordArchive] is there guidance on what should be created as a module vs being PR'd to the core repo?
Original source
is there guidance on what should be created as a module vs being PR'd to the core repo?
rektbyfaith
05-09-2023, 07:03 PM #1Archived author: KJack • Posted: 2023-05-09T19:03:04.322000+00:00
Original source
is there guidance on what should be created as a module vs being PR'd to the core repo?
Original source
There’s a bash file that creates the skeleton structure for you inside your Azerothcore repository
rektbyfaith
05-09-2023, 07:03 PM #2Archived author: Nyeriah • Posted: 2023-05-09T19:03:40.078000+00:00
Original source
There’s a bash file that creates the skeleton structure for you inside your Azerothcore repository
Original source
You just place the scripts in the file created, or create your own, up to you
rektbyfaith
05-09-2023, 07:04 PM #3Archived author: Nyeriah • Posted: 2023-05-09T19:04:13.206000+00:00
Original source
You just place the scripts in the file created, or create your own, up to you
Original source
The folder name needs to match the loader function though, so try to avoid renaming the folder
rektbyfaith
05-09-2023, 07:04 PM #4Archived author: Nyeriah • Posted: 2023-05-09T19:04:55.786000+00:00
Original source
The folder name needs to match the loader function though, so try to avoid renaming the folder
Original source
sorry, i didn't ask that well - wondering if there's certain criteria that would make something either best to be implemented as a module or best to be implemented as a core feature.
rektbyfaith
05-09-2023, 07:05 PM #5Archived author: KJack • Posted: 2023-05-09T19:05:14.625000+00:00
Original source
sorry, i didn't ask that well - wondering if there's certain criteria that would make something either best to be implemented as a module or best to be implemented as a core feature.
Original source
If it can be done in a module there's usually no reason not to
rektbyfaith
05-09-2023, 07:05 PM #6Archived author: Revision • Posted: 2023-05-09T19:05:50.287000+00:00
Original source
If it can be done in a module there's usually no reason not to
Original source
the loot group multiplier i'm working on is very similar to the referenced loot multiplier that's already in core, so i think core implementation makes a lot of sense. "sell grey items on loot" feels more module-ish to me.
rektbyfaith
05-09-2023, 07:06 PM #7Archived author: KJack • Posted: 2023-05-09T19:06:42.484000+00:00
Original source
the loot group multiplier i'm working on is very similar to the referenced loot multiplier that's already in core, so i think core implementation makes a lot of sense. "sell grey items on loot" feels more module-ish to me.
Original source
Yes, the only reasons I’d think straight to the core would be acceptable is if there’s absolutely no way to maintain it as a module, the demand is high, and it brings no impact to the performance
rektbyfaith
05-09-2023, 07:06 PM #8Archived author: Nyeriah • Posted: 2023-05-09T19:06:46.718000+00:00
Original source
Yes, the only reasons I’d think straight to the core would be acceptable is if there’s absolutely no way to maintain it as a module, the demand is high, and it brings no impact to the performance
Original source
loot group multiplier also makes changes outside of the module triggers.
rektbyfaith
05-09-2023, 07:07 PM #9Archived author: KJack • Posted: 2023-05-09T19:07:36.759000+00:00
Original source
loot group multiplier also makes changes outside of the module triggers.
Original source
hoping sell grey stuff doesn't require that
rektbyfaith
05-09-2023, 07:07 PM #10Archived author: KJack • Posted: 2023-05-09T19:07:42.152000+00:00
Original source
hoping sell grey stuff doesn't require that
1 Guest(s)
1 Guest(s)