[DiscordArchive] can you explain the purpose of it and how it relates to progression for my pea brain?
[DiscordArchive] can you explain the purpose of it and how it relates to progression for my pea brain?
Archived author: Anchy • Posted: 2023-01-04T21:41:43.489000+00:00
Original source
can you explain the purpose of it and how it relates to progression for my pea brain?
Archived author: Nyeriah • Posted: 2023-01-04T21:53:52.839000+00:00
Original source
Looks okay to me
Archived author: Revision • Posted: 2023-01-04T21:58:30.280000+00:00
Original source
Points of interest on the map for quests were added in patch 3.2 so I want the ability to disable them until that version (or higher) is enabled.
Archived author: Revision • Posted: 2023-01-04T21:58:50.245000+00:00
Original source
Sweet, thanks a ton - I'll submit a PR and if someone finds issues I'll learn from it at least.
Archived author: Nyeriah • Posted: 2023-01-04T22:01:32.368000+00:00
Original source
the only thing to keep in mind is that they should be enabled by default
Archived author: Revision • Posted: 2023-01-04T22:01:52.034000+00:00
Original source
They are absolutely enabled by default, that much I know but it's good that you point it out in case someone else doesn't know
Archived author: Anchy • Posted: 2023-01-04T22:23:29.465000+00:00
Original source
oh okay I did not know that
Archived author: Revision • Posted: 2023-01-04T22:30:21.146000+00:00
Original source
Now you do. xD
Archived author: Honey • Posted: 2023-01-05T16:55:57.172000+00:00
Original source
Did anyone make that hook work in a module?
```cpp
void OnAfterUpdateEncounterState(Map* /*map*/, EncounterCreditType /*type*/, uint32 /*creditEntry*/, Unit* /*source*/, Difficulty /*difficulty_fixed*/, DungeonEncounterList const* /*encounters*/, uint32 /*dungeonCompleted*/, bool /*updated*/)
{
LOG_ERROR("sql.sql", "Encounter completed");
}
```
I have a bunch of other `LOG_ERROR` lines, which yield an output in the logs/console. This hook apparently never happens.