[DiscordArchive] The PlayerScript hook `OnBeforePlayerQuestComplete` is not seem to work for me. I receive compilatio
[DiscordArchive] The PlayerScript hook `OnBeforePlayerQuestComplete` is not seem to work for me. I receive compilatio
Original source
The PlayerScript hook `OnBeforePlayerQuestComplete` is not seem to work for me. I receive compilation error `'PS_Transmogrification::OnBeforePlayerQuestComplete': method with override specifier 'override' did not override any base class methods` when try to override in in a PlayerScript implementation. The PlayerScript class only has the method `OnBeforeQuestComplete`. However, if I am override this method instead, then the method does not execute when a quest is completed. Is this a bug in the core or am I use it wrong?
rektbyfaith
02-24-2022, 08:02 PM #1Archived author: 郑佩茹 • Posted: 2022-02-24T20:02:51.486000+00:00
Original source
The PlayerScript hook `OnBeforePlayerQuestComplete` is not seem to work for me. I receive compilation error `'PS_Transmogrification::OnBeforePlayerQuestComplete': method with override specifier 'override' did not override any base class methods` when try to override in in a PlayerScript implementation. The PlayerScript class only has the method `OnBeforeQuestComplete`. However, if I am override this method instead, then the method does not execute when a quest is completed. Is this a bug in the core or am I use it wrong?
Original source
Launch in debugger and throw some break points to figure out the call order. Or just look up all references to the function and trace that way
rektbyfaith
02-24-2022, 08:07 PM #2Archived author: Dep • Posted: 2022-02-24T20:07:59.606000+00:00
Original source
Launch in debugger and throw some break points to figure out the call order. Or just look up all references to the function and trace that way
Original source
The only reference to `OnBeforeQuestComplete` is within `OnBeforePlayerQuestComplete`:
```
bool ScriptMgr::OnBeforePlayerQuestComplete(Player* player, uint32 quest_id)
{
auto ret = IsValidBoolScript<PlayerScript>([&](PlayerScript* script)
{
return !script->OnBeforeQuestComplete(player, quest_id);
});
if (ret && *ret)
{
return false;
}
return true;
}
```
rektbyfaith
02-24-2022, 08:10 PM #3Archived author: 郑佩茹 • Posted: 2022-02-24T20:10:26.774000+00:00
Original source
The only reference to `OnBeforeQuestComplete` is within `OnBeforePlayerQuestComplete`:
```
bool ScriptMgr::OnBeforePlayerQuestComplete(Player* player, uint32 quest_id)
{
auto ret = IsValidBoolScript<PlayerScript>([&](PlayerScript* script)
{
return !script->OnBeforeQuestComplete(player, quest_id);
});
if (ret && *ret)
{
return false;
}
return true;
}
```
Original source
There are no calls to either method anywhere else in the code. It seems it is not implemented?
rektbyfaith
02-24-2022, 08:14 PM #4Archived author: 郑佩茹 • Posted: 2022-02-24T20:14:38.163000+00:00
Original source
There are no calls to either method anywhere else in the code. It seems it is not implemented?
Original source
It seems someone deleted the call of the method. I hope it was unintended
rektbyfaith
02-24-2022, 08:16 PM #5Archived author: Nefertum • Posted: 2022-02-24T20:16:26.370000+00:00
Original source
It seems someone deleted the call of the method. I hope it was unintended
Original source
I know the database flooded a lot of the shit and I fixed a lot of miss data. Actually, the core is based on the 2019 TrinityCore source, and I keep TrinityCore importance change porting to this project. The AshamaneCore is just working on the Script. If you hate the AshamaneCore, we can rewrite it.
rektbyfaith
02-25-2022, 02:32 AM #6Archived author: JORGIE • Posted: 2022-02-25T02:32:19.401000+00:00
Original source
I know the database flooded a lot of the shit and I fixed a lot of miss data. Actually, the core is based on the 2019 TrinityCore source, and I keep TrinityCore importance change porting to this project. The AshamaneCore is just working on the Script. If you hate the AshamaneCore, we can rewrite it.
Original source
![[Image: unknown.png?ex=690c08f4&is=690ab774&hm=9...a8b6c42b2&]](https://cdn.discordapp.com/attachments/284323424032129024/946595710751612958/unknown.png?ex=690c08f4&is=690ab774&hm=9230eab1fcd60d0e69769978ba9f9813b4e6fad23bbd47dbce0081aa8b6c42b2&)
rektbyfaith
02-25-2022, 02:33 AM #7Archived author: JORGIE • Posted: 2022-02-25T02:33:24.529000+00:00
Original source
Original source
Nope. We stop dealing with anything ashamanecore when it was closed source. There was just too many issues. It may seem smooth when u login, creat new character, and spot checks, but just try playing it progressively like players do and u will run in to memory leaks, broken hooks, nonfunctioning smart ai, horrible and broken scaling, anything garrison system is hard broken and class halls are linked to the class hall system. All halls are busted. Artifacts... only some work. Good luck getting argus to function smoothly, npc defense ai for broken shore is busted. Invasions do not work. Nearly about 70% of the whole core itself is both incomplete and also missing. You will waste more time bringing up to current tc standards then you would hust branching off of tc master when it was 26972. Pet didnt work. Db2 files were not extracting properly; half the spells dont work.
rektbyfaith
02-25-2022, 02:52 AM #8Archived author: M'Dic • Posted: 2022-02-25T02:52:05.318000+00:00
Original source
Nope. We stop dealing with anything ashamanecore when it was closed source. There was just too many issues. It may seem smooth when u login, creat new character, and spot checks, but just try playing it progressively like players do and u will run in to memory leaks, broken hooks, nonfunctioning smart ai, horrible and broken scaling, anything garrison system is hard broken and class halls are linked to the class hall system. All halls are busted. Artifacts... only some work. Good luck getting argus to function smoothly, npc defense ai for broken shore is busted. Invasions do not work. Nearly about 70% of the whole core itself is both incomplete and also missing. You will waste more time bringing up to current tc standards then you would hust branching off of tc master when it was 26972. Pet didnt work. Db2 files were not extracting properly; half the spells dont work.
Original source
Scenarios are empty/dead, opcodes some are just wrong and never corrected. U have better chance getting bshop working on it then u do all the rest of the content.
rektbyfaith
02-25-2022, 02:54 AM #9Archived author: M'Dic • Posted: 2022-02-25T02:54:34.470000+00:00
Original source
Scenarios are empty/dead, opcodes some are just wrong and never corrected. U have better chance getting bshop working on it then u do all the rest of the content.
Original source
Actually, after I tested a few LegionCore, including the source code leaking from uwow.com in 2020, I found this core more stable than them. At least, the character's skill work. I don't know which core is the best choice to make a playable server after the wow 335 version. I sole have an investigation on SkyFire_548. this project has a lot of things brought from Mongo and TrinityCore. It's hard to make a playable core. The hotfixes is not implemented.
rektbyfaith
02-25-2022, 05:55 AM #10Archived author: JORGIE • Posted: 2022-02-25T05:55:37.241000+00:00
Original source
Actually, after I tested a few LegionCore, including the source code leaking from uwow.com in 2020, I found this core more stable than them. At least, the character's skill work. I don't know which core is the best choice to make a playable server after the wow 335 version. I sole have an investigation on SkyFire_548. this project has a lot of things brought from Mongo and TrinityCore. It's hard to make a playable core. The hotfixes is not implemented.
1 Guest(s)
1 Guest(s)