[DiscordArchive] Okay because there's several "ignore FD" functions, some of them that seem to be breaking pets, but
[DiscordArchive] Okay because there's several "ignore FD" functions, some of them that seem to be breaking pets, but
Original source
Okay because there's several "ignore FD" functions, some of them that seem to be breaking pets, but maybe that's just dead code that is never reached. Not sure how to bring that discussion up... discussion on github? Make a PR that attempts at fixing ?
rektbyfaith
10-17-2021, 02:17 PM #1Archived author: Drooppi • Posted: 2021-10-17T14:17:05.519000+00:00
Original source
Okay because there's several "ignore FD" functions, some of them that seem to be breaking pets, but maybe that's just dead code that is never reached. Not sure how to bring that discussion up... discussion on github? Make a PR that attempts at fixing ?
Original source
can't help there lol. i'm a complete noob with c++. I just test other people's fixes. lol. personally, i think a PR would probably be good. then all the gods here would see and could contribute their thoughts/fixes too.
rektbyfaith
10-17-2021, 02:24 PM #2Archived author: Luke • Posted: 2021-10-17T14:24:54.896000+00:00
Original source
can't help there lol. i'm a complete noob with c++. I just test other people's fixes. lol. personally, i think a PR would probably be good. then all the gods here would see and could contribute their thoughts/fixes too.
Original source
Code discussions should always happen on GitHub. You can Just raise an issue or open a Pr
rektbyfaith
10-17-2021, 02:27 PM #3Archived author: Honey • Posted: 2021-10-17T14:27:35.111000+00:00
Original source
Code discussions should always happen on GitHub. You can Just raise an issue or open a Pr
Original source
Right, people will comment on the Code and make sure the standards are in place as well as recommend improvements
rektbyfaith
10-17-2021, 02:28 PM #4Archived author: Honey • Posted: 2021-10-17T14:28:23.719000+00:00
Original source
Right, people will comment on the Code and make sure the standards are in place as well as recommend improvements
Original source
Yes I'm familiar with PRs, it's just that... the issue affects from the shaman elementals all the way to twin emperors and some bosses in wotlk
rektbyfaith
10-17-2021, 02:29 PM #5Archived author: Drooppi • Posted: 2021-10-17T14:29:03.755000+00:00
Original source
Yes I'm familiar with PRs, it's just that... the issue affects from the shaman elementals all the way to twin emperors and some bosses in wotlk
Original source
and it probably also affects pets
rektbyfaith
10-17-2021, 02:29 PM #6Archived author: Drooppi • Posted: 2021-10-17T14:29:14.567000+00:00
Original source
and it probably also affects pets
Original source
ah well, I'll just fix them one by one in a commit each and post a PR
rektbyfaith
10-17-2021, 02:29 PM #7Archived author: Drooppi • Posted: 2021-10-17T14:29:35.301000+00:00
Original source
ah well, I'll just fix them one by one in a commit each and post a PR