Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] In answer to this bug: I believe I've managed to solve it with a hackfix by changing line 6627 on fi

[DiscordArchive] In answer to this bug: I believe I've managed to solve it with a hackfix by changing line 6627 on fi

[DiscordArchive] In answer to this bug: I believe I've managed to solve it with a hackfix by changing line 6627 on fi

rektbyfaith
Administrator
Find
0
07-01-2021, 07:41 PM
#1
Archived author: Henrique Souza • Posted: 2021-07-01T19:41:38.772000+00:00
Original source

In answer to this bug: I believe I've managed to solve it with a hackfix by changing line 6627 on file Player.cpp from
```if (max != 1)```
to
```if ((max != 1) && !IsProfessionOrRidingSkill(pskill))```

I still don't know why Professions kept passing through the filter of GetSkillRangeType(rcEntry) != SKILL_RANGE_LEVEL on line 6617, which I'll keep investigating.

Should I open an issue about this on github with what I've got so far?
Reply
Reply
rektbyfaith
07-01-2021, 07:41 PM #1

Archived author: Henrique Souza • Posted: 2021-07-01T19:41:38.772000+00:00
Original source

In answer to this bug: I believe I've managed to solve it with a hackfix by changing line 6627 on file Player.cpp from
```if (max != 1)```
to
```if ((max != 1) && !IsProfessionOrRidingSkill(pskill))```

I still don't know why Professions kept passing through the filter of GetSkillRangeType(rcEntry) != SKILL_RANGE_LEVEL on line 6617, which I'll keep investigating.

Should I open an issue about this on github with what I've got so far?

Reply
Reply
rektbyfaith
Administrator
Find
0
07-01-2021, 07:45 PM
#2
Archived author: Honey • Posted: 2021-07-01T19:45:35.198000+00:00
Original source

one should always take coding to github. it gets lost in chat on discord way too easy
Reply
Reply
rektbyfaith
07-01-2021, 07:45 PM #2

Archived author: Honey • Posted: 2021-07-01T19:45:35.198000+00:00
Original source

one should always take coding to github. it gets lost in chat on discord way too easy

Reply
Reply
rektbyfaith
Administrator
Find
0
07-01-2021, 08:50 PM
#3
Archived author: Henrique Souza • Posted: 2021-07-01T20:50:10.518000+00:00
Original source

Ok, thanks, I shall do that
Reply
Reply
rektbyfaith
07-01-2021, 08:50 PM #3

Archived author: Henrique Souza • Posted: 2021-07-01T20:50:10.518000+00:00
Original source

Ok, thanks, I shall do that

Reply
Reply
rektbyfaith
Administrator
Find
0
07-01-2021, 10:37 PM
#4
Archived author: Henrique Souza • Posted: 2021-07-01T22:37:30.784000+00:00
Original source

I actually found a related issue posted a week ago: https://github.com/azerothcore/azerothco...ssues/6563

I've commented there with what I think is the root of the problem and a better temporary fix than the one above, but in sum there may be some tables running empty
[Embed: Riding tied to level of your character · Issue #6563 · azerothcore/...]
CURRENT BEHAVIOUR: If you learn riding, it will give the appropriate skill level (75/75, 150/150 etc.) But, if you re-log, the riding skill points will tie to the level of your character. EXPECTED ...
https://github.com/azerothcore/azerothco...ssues/6563
Reply
Reply
rektbyfaith
07-01-2021, 10:37 PM #4

Archived author: Henrique Souza • Posted: 2021-07-01T22:37:30.784000+00:00
Original source

I actually found a related issue posted a week ago: https://github.com/azerothcore/azerothco...ssues/6563

I've commented there with what I think is the root of the problem and a better temporary fix than the one above, but in sum there may be some tables running empty
[Embed: Riding tied to level of your character · Issue #6563 · azerothcore/...]
CURRENT BEHAVIOUR: If you learn riding, it will give the appropriate skill level (75/75, 150/150 etc.) But, if you re-log, the riding skill points will tie to the level of your character. EXPECTED ...
https://github.com/azerothcore/azerothco...ssues/6563

Reply
Reply
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)