[DiscordArchive] what is the compile error?
[DiscordArchive] what is the compile error?
Original source
xd
rektbyfaith
05-11-2020, 07:46 PM #31Archived author: Kitzunu • Posted: 2020-05-11T19:46:31.409000+00:00
Original source
xd
Original source
the alternative to deleting lines 18963 and 18978 is to change 18996:
from
if (m && fields[20].GetBool() /* has_items */ && fields[12].GetUInt32() /* itemEntry */)
to
if (m && has_items && fields[12].GetUInt32() /* itemEntry */)
rektbyfaith
05-11-2020, 07:47 PM #32Archived author: MishaParem • Posted: 2020-05-11T19:47:46.866000+00:00
Original source
the alternative to deleting lines 18963 and 18978 is to change 18996:
from
if (m && fields[20].GetBool() /* has_items */ && fields[12].GetUInt32() /* itemEntry */)
to
if (m && has_items && fields[12].GetUInt32() /* itemEntry */)
Original source
but if you change 18978 to bool has_items it still fails?
rektbyfaith
05-11-2020, 07:48 PM #33Archived author: Kitzunu • Posted: 2020-05-11T19:48:38.716000+00:00
Original source
but if you change 18978 to bool has_items it still fails?
Original source
I am trying to figure out what the reasoning to adding it in the first place were, but Github won't load that many lines in the file
rektbyfaith
05-11-2020, 07:49 PM #34Archived author: Kitzunu • Posted: 2020-05-11T19:49:20.042000+00:00
Original source
I am trying to figure out what the reasoning to adding it in the first place were, but Github won't load that many lines in the file
Original source
Q.Q
rektbyfaith
05-11-2020, 07:49 PM #35Archived author: Kitzunu • Posted: 2020-05-11T19:49:21.474000+00:00
Original source
Q.Q
Original source
I haven't actually tried. The compiler warning w/o change leads me to believe that it doesn't matter where we assign a value to has_items, if it's never used, the warning will persist
rektbyfaith
05-11-2020, 07:50 PM #36Archived author: MishaParem • Posted: 2020-05-11T19:50:26.725000+00:00
Original source
I haven't actually tried. The compiler warning w/o change leads me to believe that it doesn't matter where we assign a value to has_items, if it's never used, the warning will persist
Original source
gimme a sec I'll try the change and see what the compiler says
rektbyfaith
05-11-2020, 07:50 PM #37Archived author: MishaParem • Posted: 2020-05-11T19:50:45.374000+00:00
Original source
gimme a sec I'll try the change and see what the compiler says
Original source
https://github.com/azerothcore/azerothco...b8aad9512c
[Embed: Removed more warnings, mostly related to unused-variable · azerothc...]
issue #121
We still have to work on unused-parameter
https://github.com/azerothcore/azerothco...b8aad9512c
rektbyfaith
05-11-2020, 07:51 PM #38Archived author: Kitzunu • Posted: 2020-05-11T19:51:05.439000+00:00
Original source
https://github.com/azerothcore/azerothco...b8aad9512c
[Embed: Removed more warnings, mostly related to unused-variable · azerothc...]
issue #121
We still have to work on unused-parameter
https://github.com/azerothcore/azerothco...b8aad9512c
Original source
the commit that changed this
rektbyfaith
05-11-2020, 07:51 PM #39Archived author: Kitzunu • Posted: 2020-05-11T19:51:12.919000+00:00
Original source
the commit that changed this
Original source
rektbyfaith
05-11-2020, 07:51 PM #40Archived author: Kitzunu • Posted: 2020-05-11T19:51:13.476000+00:00
Original source
1 Guest(s)
1 Guest(s)