Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] should I open an issue on GitHub about config values under `SkillChance` in `worldserver.conf` never

[DiscordArchive] should I open an issue on GitHub about config values under `SkillChance` in `worldserver.conf` never

[DiscordArchive] should I open an issue on GitHub about config values under `SkillChance` in `worldserver.conf` never

rektbyfaith
Administrator
0
04-06-2019, 09:29 AM
#1
Archived author: jf1x • Posted: 2019-04-06T09:29:35.792000+00:00
Original source

should I open an issue on GitHub about config values under `SkillChance` in `worldserver.conf` never actually being used?
rektbyfaith
04-06-2019, 09:29 AM #1

Archived author: jf1x • Posted: 2019-04-06T09:29:35.792000+00:00
Original source

should I open an issue on GitHub about config values under `SkillChance` in `worldserver.conf` never actually being used?

rektbyfaith
Administrator
0
04-06-2019, 09:30 AM
#2
Archived author: Nix • Posted: 2019-04-06T09:30:26.512000+00:00
Original source

<@!207901137267851264> I might be able to write a fix for you soon, but I'm a bit busy atm
rektbyfaith
04-06-2019, 09:30 AM #2

Archived author: Nix • Posted: 2019-04-06T09:30:26.512000+00:00
Original source

<@!207901137267851264> I might be able to write a fix for you soon, but I'm a bit busy atm

rektbyfaith
Administrator
0
04-06-2019, 09:32 AM
#3
Archived author: jf1x • Posted: 2019-04-06T09:32:22.674000+00:00
Original source

actually ignore the above question, I don't think GitHub search works 100% on all the code, seems to miss some instances. I'll do a proper search via command line
rektbyfaith
04-06-2019, 09:32 AM #3

Archived author: jf1x • Posted: 2019-04-06T09:32:22.674000+00:00
Original source

actually ignore the above question, I don't think GitHub search works 100% on all the code, seems to miss some instances. I'll do a proper search via command line

rektbyfaith
Administrator
0
04-06-2019, 09:39 AM
#4
Archived author: Nix • Posted: 2019-04-06T09:39:16.295000+00:00
Original source

<@155863792734044160> It definitely does miss some of the instances where code should've been found. I switched to using vs code with a local copy of any repo that I need to search often
rektbyfaith
04-06-2019, 09:39 AM #4

Archived author: Nix • Posted: 2019-04-06T09:39:16.295000+00:00
Original source

<@155863792734044160> It definitely does miss some of the instances where code should've been found. I switched to using vs code with a local copy of any repo that I need to search often

rektbyfaith
Administrator
0
04-06-2019, 09:53 AM
#5
Archived author: Viste • Posted: 2019-04-06T09:53:29.398000+00:00
Original source

<@&262884577805074432> https://github.com/azerothcore/azerothco.../pull/1643
[Embed: BG Queue Announcer FIX by wizzymore · Pull Request #1643 · azero...]
CHANGES PROPOSED:

Show to the player or to the world ( config based ) the queue status for the current bg

ISSUES ADDRESSED:

Closes
TESTS PERFORMED:


Windows
Linux

HOW TO TEST THE CHANGES:

G...
https://github.com/azerothcore/azerothco.../pull/1643
rektbyfaith
04-06-2019, 09:53 AM #5

Archived author: Viste • Posted: 2019-04-06T09:53:29.398000+00:00
Original source

<@&262884577805074432> https://github.com/azerothcore/azerothco.../pull/1643
[Embed: BG Queue Announcer FIX by wizzymore · Pull Request #1643 · azero...]
CHANGES PROPOSED:

Show to the player or to the world ( config based ) the queue status for the current bg

ISSUES ADDRESSED:

Closes
TESTS PERFORMED:


Windows
Linux

HOW TO TEST THE CHANGES:

G...
https://github.com/azerothcore/azerothco.../pull/1643

rektbyfaith
Administrator
0
04-06-2019, 09:54 AM
#6
Archived author: Viste • Posted: 2019-04-06T09:54:43.279000+00:00
Original source

rektbyfaith
04-06-2019, 09:54 AM #6

Archived author: Viste • Posted: 2019-04-06T09:54:43.279000+00:00
Original source

rektbyfaith
Administrator
0
04-06-2019, 10:11 AM
#7
Archived author: Walkmyshoes • Posted: 2019-04-06T10:11:58.614000+00:00
Original source

Can confirm it s working wonderfull
rektbyfaith
04-06-2019, 10:11 AM #7

Archived author: Walkmyshoes • Posted: 2019-04-06T10:11:58.614000+00:00
Original source

Can confirm it s working wonderfull

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)