[DiscordArchive] in TC are `m_bool_configs` loaded when that line is called?

Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] in TC are `m_bool_configs` loaded when that line is called?

Pages (4): Previous 1 2 3 4 Next

rektbyfaith
Administrator

01-06-2019, 05:19 PM

#21

Archived author: Nefertum • Posted: 2019-01-06T17:19:06.645000+00:00
Original source

https://github.com/TrinityCore/TrinityCo...p.in.cmake
[Embed: TrinityCore/TrinityCore]
TrinityCore Open Source MMO Framework (master = 8.0.1.28153, 3.3.5 = 3.3.5a.12340) - TrinityCore/TrinityCore
https://github.com/TrinityCore/TrinityCo...p.in.cmake

rektbyfaith

01-06-2019, 05:19 PM #21

rektbyfaith
Administrator

01-06-2019, 05:19 PM

#22

Archived author: Shin • Posted: 2019-01-06T17:19:52.829000+00:00
Original source

<@217695958694100992> check if you see something useful here: https://github.com/TrinityCore/TrinityCo...Loader.cpp
[Embed: TrinityCore/TrinityCore]
TrinityCore Open Source MMO Framework (master = 8.0.1.28153, 3.3.5 = 3.3.5a.12340) - TrinityCore/TrinityCore
https://github.com/TrinityCore/TrinityCo...Loader.cpp

rektbyfaith

01-06-2019, 05:19 PM #22

rektbyfaith
Administrator

01-06-2019, 05:30 PM

#23

Archived author: Nefertum • Posted: 2019-01-06T17:30:09.097000+00:00
Original source

I didn't find any relevant

rektbyfaith

01-06-2019, 05:30 PM #23

Archived author: Nefertum • Posted: 2019-01-06T17:30:09.097000+00:00
Original source

I didn't find any relevant

rektbyfaith
Administrator

01-06-2019, 05:30 PM

#24

Archived author: Nefertum • Posted: 2019-01-06T17:30:12.120000+00:00
Original source

But... https://github.com/TrinityCore/TrinityCo...cdcb01cR54
[Embed: Core/Scripts: Split the huge scriptloader into smaller pieces · T...]
* Each subdirectory contains it's own translation unit now
which is responsible for loading it's directory
* Improves merging & decoupling between 3.3.5 <-> 6.x
* Removes unused...
https://github.com/TrinityCore/TrinityCo...b2b6fc7c69

rektbyfaith

01-06-2019, 05:30 PM #24

rektbyfaith
Administrator

01-06-2019, 05:31 PM

#25

Archived author: Shin • Posted: 2019-01-06T17:31:35.034000+00:00
Original source

and it's still that way: https://github.com/TrinityCore/TrinityCo...er.cpp#L55
[Embed: TrinityCore/TrinityCore]
TrinityCore Open Source MMO Framework (master = 8.0.1.28153, 3.3.5 = 3.3.5a.12340) - TrinityCore/TrinityCore
https://github.com/TrinityCore/TrinityCo...loader.cpp

rektbyfaith

01-06-2019, 05:31 PM #25

rektbyfaith
Administrator

01-06-2019, 05:32 PM

#26

Archived author: Nefertum • Posted: 2019-01-06T17:32:34.599000+00:00
Original source

Yes

rektbyfaith

01-06-2019, 05:32 PM #26

Archived author: Nefertum • Posted: 2019-01-06T17:32:34.599000+00:00
Original source

Yes

rektbyfaith
Administrator

01-06-2019, 05:32 PM

#27

Archived author: Nefertum • Posted: 2019-01-06T17:32:41.103000+00:00
Original source

And i think trinity has the same problem

rektbyfaith

01-06-2019, 05:32 PM #27

Archived author: Nefertum • Posted: 2019-01-06T17:32:41.103000+00:00
Original source

And i think trinity has the same problem

rektbyfaith
Administrator

01-06-2019, 05:34 PM

#28

Archived author: Nefertum • Posted: 2019-01-06T17:34:35.472000+00:00
Original source

We should move it

rektbyfaith

01-06-2019, 05:34 PM #28

Archived author: Nefertum • Posted: 2019-01-06T17:34:35.472000+00:00
Original source

We should move it

rektbyfaith
Administrator

01-06-2019, 05:42 PM

#29

Archived author: Nefertum • Posted: 2019-01-06T17:42:32.185000+00:00
Original source

I don't know if it's a good practice (not efficient at least) but the way i think we can fix the pr is call the getBoolConfig at the functions

rektbyfaith

01-06-2019, 05:42 PM #29

rektbyfaith
Administrator

01-06-2019, 05:43 PM

#30

Archived author: Nefertum • Posted: 2019-01-06T17:43:57.648000+00:00
Original source

I don't like it really much because it will call the hooks anyway

rektbyfaith

01-06-2019, 05:43 PM #30

Archived author: Nefertum • Posted: 2019-01-06T17:43:57.648000+00:00
Original source

I don't like it really much because it will call the hooks anyway

Pages (4): Previous 1 2 3 4 Next

Recently Browsing
1 Guest(s)