[DiscordArchive] 1) we're talking about logging, it doesn't fix nothing
[DiscordArchive] 1) we're talking about logging, it doesn't fix nothing
Original source
<@!307220419021373440> i've fixed merging conflicts for your PR and adding 2 examples: https://github.com/azerothcore/azerothco...709c8cc362
[Embed: Reenabled all logging functions by BarbzYHOOL · Pull Request #519 · azerothcore/azerothcore-wotlk]
Changes proposed:
Reenabled debug logging functions (sLog) (1000+ lines)
Fixed all errors thanks to @talamortis (260 more)
Target branch(es): 1.x/2.x etc.
Issues addressed: Some people wanted the...
https://github.com/azerothcore/azerothco...709c8cc362
rektbyfaith
08-19-2017, 04:41 PM #21Archived author: Yehonal • Posted: 2017-08-19T16:41:27.561000+00:00
Original source
<@!307220419021373440> i've fixed merging conflicts for your PR and adding 2 examples: https://github.com/azerothcore/azerothco...709c8cc362
[Embed: Reenabled all logging functions by BarbzYHOOL · Pull Request #519 · azerothcore/azerothcore-wotlk]
Changes proposed:
Reenabled debug logging functions (sLog) (1000+ lines)
Fixed all errors thanks to @talamortis (260 more)
Target branch(es): 1.x/2.x etc.
Issues addressed: Some people wanted the...
https://github.com/azerothcore/azerothco...709c8cc362
Original source
the bad news is that you should add
```
#if defined(DISABLE_EXTRAS) || defined(DISABLE_EXTRA_LOGS)
#endif
```
sourrounding the rest of x-2 logging functions :-(
Good luck
rektbyfaith
08-19-2017, 04:42 PM #22Archived author: Yehonal • Posted: 2017-08-19T16:42:36.788000+00:00
Original source
the bad news is that you should add
```
#if defined(DISABLE_EXTRAS) || defined(DISABLE_EXTRA_LOGS)
#endif
```
sourrounding the rest of x-2 logging functions :-(
Good luck
Original source
hopefully nobody needs them
rektbyfaith
08-19-2017, 04:45 PM #23Archived author: Barbz • Posted: 2017-08-19T16:45:03.316000+00:00
Original source
hopefully nobody needs them
Original source
well you know, imho would be a 2 seconds task if we close your actual PR and use a script to add a row before and after ;//sLog(.*) , removing comment ;//
rektbyfaith
08-19-2017, 04:47 PM #24Archived author: Yehonal • Posted: 2017-08-19T16:47:56.389000+00:00
Original source
well you know, imho would be a 2 seconds task if we close your actual PR and use a script to add a row before and after ;//sLog(.*) , removing comment ;//
Original source
i can try
rektbyfaith
08-19-2017, 04:48 PM #25Archived author: Yehonal • Posted: 2017-08-19T16:48:01.217000+00:00
Original source
i can try
Original source
well, we need also to import your compilation commits after, i'll try asap
rektbyfaith
08-19-2017, 04:50 PM #26Archived author: Yehonal • Posted: 2017-08-19T16:50:13.464000+00:00
Original source
well, we need also to import your compilation commits after, i'll try asap
Original source
there were 230 lines that were modified by talamortis to compile correctly
rektbyfaith
08-19-2017, 04:55 PM #27Archived author: Barbz • Posted: 2017-08-19T16:55:29.168000+00:00
Original source
there were 230 lines that were modified by talamortis to compile correctly
Original source
and how do you add a row "after" the comment
rektbyfaith
08-19-2017, 04:55 PM #28Archived author: Barbz • Posted: 2017-08-19T16:55:51.196000+00:00
Original source
and how do you add a row "after" the comment
Original source
that's the problem
rektbyfaith
08-19-2017, 04:55 PM #29Archived author: Barbz • Posted: 2017-08-19T16:55:55.752000+00:00
Original source
that's the problem
Original source
there is no recurring pattern but "find the next ";""
rektbyfaith
08-19-2017, 04:56 PM #30Archived author: Barbz • Posted: 2017-08-19T16:56:24.089000+00:00
Original source
there is no recurring pattern but "find the next ";""
1 Guest(s)
1 Guest(s)