[DiscordArchive] 1) we're talking about logging, it doesn't fix nothing
[DiscordArchive] 1) we're talking about logging, it doesn't fix nothing
Original source
Commented out code does not fix the root cause of an issue.. its like having weeds on your lawn... and instead of putting poison on said weeds.. all your doing is taking a patch out and placing it one square inch below the dirt
rektbyfaith
08-19-2017, 03:30 PM #11Archived author: krill8709 • Posted: 2017-08-19T15:30:11.041000+00:00
Original source
Commented out code does not fix the root cause of an issue.. its like having weeds on your lawn... and instead of putting poison on said weeds.. all your doing is taking a patch out and placing it one square inch below the dirt
Original source
Do you know how a compiler work <@138614645060534272> ?
rektbyfaith
08-19-2017, 03:31 PM #12Archived author: Yehonal • Posted: 2017-08-19T15:31:44.840000+00:00
Original source
Do you know how a compiler work <@138614645060534272> ?
Original source
its just about logs
rektbyfaith
08-19-2017, 03:31 PM #13Archived author: Barbz • Posted: 2017-08-19T15:31:46.988000+00:00
Original source
its just about logs
Original source
because seems that you're talking like an Alchemist of Maths things...
rektbyfaith
08-19-2017, 03:32 PM #14Archived author: Yehonal • Posted: 2017-08-19T15:32:17+00:00
Original source
because seems that you're talking like an Alchemist of Maths things...
Original source
i cant find any of it right now, but when i saw it when some one posted it up on northcraft, i about gouged out my eyeballs looking at a movement state being commeted out and unhandled (might of been different, i cant recall and it goes way to far back in the chat history to find any exacts)
rektbyfaith
08-19-2017, 03:47 PM #15Archived author: krill8709 • Posted: 2017-08-19T15:47:05.849000+00:00
Original source
i cant find any of it right now, but when i saw it when some one posted it up on northcraft, i about gouged out my eyeballs looking at a movement state being commeted out and unhandled (might of been different, i cant recall and it goes way to far back in the chat history to find any exacts)
Original source
here you are what i mean: https://github.com/azerothcore/azerothco.../567/files
[Embed: Preprocessor option for logging functions by Yehonal · Pull Request #567 · azerothcore/azerothcore-wotlk]
Changes proposed:
implement preprocessor option to enable/disable extra logging function. It can reduce performances
Target branch(es): master
https://github.com/azerothcore/azerothco.../567/files
rektbyfaith
08-19-2017, 04:04 PM #16Archived author: Yehonal • Posted: 2017-08-19T16:04:04.466000+00:00
Original source
here you are what i mean: https://github.com/azerothcore/azerothco.../567/files
[Embed: Preprocessor option for logging functions by Yehonal · Pull Request #567 · azerothcore/azerothcore-wotlk]
Changes proposed:
implement preprocessor option to enable/disable extra logging function. It can reduce performances
Target branch(es): master
https://github.com/azerothcore/azerothco.../567/files
Original source
<@138614645060534272> we are talking about logging, logging has been disabled for performance....not to fix something
rektbyfaith
08-19-2017, 04:04 PM #17Archived author: Yehonal • Posted: 2017-08-19T16:04:23.564000+00:00
Original source
<@138614645060534272> we are talking about logging, logging has been disabled for performance....not to fix something
Original source
performances has been analyzed with valgrind https://github.com/Kittnz/Sunwell/tree/m...b/valgrind
[Embed: Kittnz/Sunwell]
Sunwell - by xinef & pussywizard
https://github.com/Kittnz/Sunwell/tree/m...b/valgrind
rektbyfaith
08-19-2017, 04:04 PM #18Archived author: Yehonal • Posted: 2017-08-19T16:04:46.531000+00:00
Original source
performances has been analyzed with valgrind https://github.com/Kittnz/Sunwell/tree/m...b/valgrind
[Embed: Kittnz/Sunwell]
Sunwell - by xinef & pussywizard
https://github.com/Kittnz/Sunwell/tree/m...b/valgrind
Original source
so, we've just to improve <@!307220419021373440> PR with preprocessor condition and if you need more logs, then you can enable them
rektbyfaith
08-19-2017, 04:05 PM #19Archived author: Yehonal • Posted: 2017-08-19T16:05:12.866000+00:00
Original source
so, we've just to improve <@!307220419021373440> PR with preprocessor condition and if you need more logs, then you can enable them
Original source
but in a production environment you can safely disable them
rektbyfaith
08-19-2017, 04:05 PM #20Archived author: Yehonal • Posted: 2017-08-19T16:05:30.555000+00:00
Original source
but in a production environment you can safely disable them
1 Guest(s)
1 Guest(s)