[DiscordArchive] This feels like one of those questions that's almost too obvious to ask given how long the code has
[DiscordArchive] This feels like one of those questions that's almost too obvious to ask given how long the code has
Original source
This feels like one of those questions that's almost too obvious to ask given how long the code has been in place, but is daily quests not giving XP when repeated intended behavior?
rektbyfaith
10-09-2025, 04:08 PM #1Archived author: Grace • Posted: 2025-10-09T16:08:24.629000+00:00
Original source
This feels like one of those questions that's almost too obvious to ask given how long the code has been in place, but is daily quests not giving XP when repeated intended behavior?
Original source
Which daily quest(s)? Don't believe that is intended
rektbyfaith
10-09-2025, 04:08 PM #2Archived author: Bench • Posted: 2025-10-09T16:08:56.402000+00:00
Original source
Which daily quest(s)? Don't believe that is intended
Original source
All of them, I think - this code from PlayerQuest.cpp zeros out the XP for them from the 2nd and subsequent times:
`bool rewarded = IsQuestRewarded(quest_id) && !quest->IsDFQuest();
// Not give XP in case already completed once repeatable quest
uint32 XP = rewarded ? 0 : CalculateQuestRewardXP(quest);`
rektbyfaith
10-09-2025, 04:09 PM #3Archived author: Grace • Posted: 2025-10-09T16:09:56.983000+00:00
Original source
All of them, I think - this code from PlayerQuest.cpp zeros out the XP for them from the 2nd and subsequent times:
`bool rewarded = IsQuestRewarded(quest_id) && !quest->IsDFQuest();
// Not give XP in case already completed once repeatable quest
uint32 XP = rewarded ? 0 : CalculateQuestRewardXP(quest);`
Original source
Repeatable quests are not the same as daily/weekly quests for the record
rektbyfaith
10-09-2025, 04:10 PM #4Archived author: Bench • Posted: 2025-10-09T16:10:49.766000+00:00
Original source
Repeatable quests are not the same as daily/weekly quests for the record
Original source
No sure, but what I mean is that this code that's setting XP to 0 is also hitting daily quests - there's no exception there (`&& !quest->IsDaily()`)
rektbyfaith
10-09-2025, 04:11 PM #5Archived author: Grace • Posted: 2025-10-09T16:11:57.367000+00:00
Original source
No sure, but what I mean is that this code that's setting XP to 0 is also hitting daily quests - there's no exception there (`&& !quest->IsDaily()`)
Original source
Just tested in-game, you are correct. That is not intended behavior
rektbyfaith
10-09-2025, 04:14 PM #6Archived author: Bench • Posted: 2025-10-09T16:14:50.245000+00:00
Original source
Just tested in-game, you are correct. That is not intended behavior
Original source
Thank you for looking into it! I'm not an experienced C++ person at all but for what it's worth I think adding that extra conditional is probably all that's needed - I don't think it'll mess anything else up as that's the only place `rewarded` is used. It will I think change gold rewards at max level, but I suspect only correctly.
rektbyfaith
10-09-2025, 04:17 PM #7Archived author: Grace • Posted: 2025-10-09T16:17:31.164000+00:00
Original source
Thank you for looking into it! I'm not an experienced C++ person at all but for what it's worth I think adding that extra conditional is probably all that's needed - I don't think it'll mess anything else up as that's the only place `rewarded` is used. It will I think change gold rewards at max level, but I suspect only correctly.
Original source
https://github.com/azerothcore/azerothco...pull/23160
Have not tested it, but I see no reason it wouldn't correct the issue
rektbyfaith
10-09-2025, 04:22 PM #8Archived author: Bench • Posted: 2025-10-09T16:22:17.306000+00:00
Original source
https://github.com/azerothcore/azerothco...pull/23160
Have not tested it, but I see no reason it wouldn't correct the issue
Original source
As my more amateurish fix did, I know it will! Thank you again
rektbyfaith
10-09-2025, 04:24 PM #9Archived author: Grace • Posted: 2025-10-09T16:24:09.771000+00:00
Original source
As my more amateurish fix did, I know it will! Thank you again
Original source
Did you notice that in-game or from looking at the code here?
rektbyfaith
10-09-2025, 04:24 PM #10Archived author: Bench • Posted: 2025-10-09T16:24:35.703000+00:00
Original source
Did you notice that in-game or from looking at the code here?
1 Guest(s)
1 Guest(s)