[DiscordArchive] in RemovePlayerFromMap ?
[DiscordArchive] in RemovePlayerFromMap ?
Original source
```
void InstanceMap::RemovePlayerFromMap(Player* player, bool remove)
{
..
Map::RemovePlayerFromMap(player, remove);
// If remove == true - player already deleted.
if (!remove)
player->SetPendingBind(0, 0);
if (instance_data)
instance_data->OnPlayerLeave(player);
}
```
rektbyfaith
01-10-2025, 01:39 PM #11Archived author: OUTRAKE • Posted: 2025-01-10T13:39:10.404000+00:00
Original source
```
void InstanceMap::RemovePlayerFromMap(Player* player, bool remove)
{
..
Map::RemovePlayerFromMap(player, remove);
// If remove == true - player already deleted.
if (!remove)
player->SetPendingBind(0, 0);
if (instance_data)
instance_data->OnPlayerLeave(player);
}
```
Original source
like that
rektbyfaith
01-10-2025, 01:39 PM #12Archived author: OUTRAKE • Posted: 2025-01-10T13:39:11.993000+00:00
Original source
like that
Original source
let me check
rektbyfaith
01-10-2025, 01:39 PM #13Archived author: OUTRAKE • Posted: 2025-01-10T13:39:44.509000+00:00
Original source
let me check
Original source
yea it works
rektbyfaith
01-10-2025, 01:43 PM #14Archived author: OUTRAKE • Posted: 2025-01-10T13:43:01.410000+00:00
Original source
yea it works
Original source
nyeriah can you help with code refactor to optimize that pr?
rektbyfaith
01-10-2025, 01:56 PM #15Archived author: OUTRAKE • Posted: 2025-01-10T13:56:21.972000+00:00
Original source
nyeriah can you help with code refactor to optimize that pr?
Original source
we can merge it if its functional and optmize it later if its just codestyle/DRY
rektbyfaith
01-10-2025, 02:00 PM #16Archived author: Nyeriah • Posted: 2025-01-10T14:00:27.391000+00:00
Original source
we can merge it if its functional and optmize it later if its just codestyle/DRY
Original source
Yea its functional rn, codestyle keep giving error about trailing spaces idk why
rektbyfaith
01-10-2025, 02:03 PM #17Archived author: OUTRAKE • Posted: 2025-01-10T14:03:48.866000+00:00
Original source
Yea its functional rn, codestyle keep giving error about trailing spaces idk why
Original source
yeah I am not seeing those white spaces myself
rektbyfaith
01-10-2025, 02:10 PM #18Archived author: Nyeriah • Posted: 2025-01-10T14:10:12.670000+00:00
Original source
yeah I am not seeing those white spaces myself
Original source
line endings maybe
rektbyfaith
01-10-2025, 02:12 PM #19Archived author: Nyeriah • Posted: 2025-01-10T14:12:15.906000+00:00
Original source
line endings maybe
Original source
not sure how that would happen though
rektbyfaith
01-10-2025, 02:12 PM #20Archived author: Nyeriah • Posted: 2025-01-10T14:12:24.572000+00:00
Original source
not sure how that would happen though
1 Guest(s)
1 Guest(s)