Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] I'm sorry but that doesn't even make sense. Add code to an existing project or rewrite it from the g

[DiscordArchive] I'm sorry but that doesn't even make sense. Add code to an existing project or rewrite it from the g

[DiscordArchive] I'm sorry but that doesn't even make sense. Add code to an existing project or rewrite it from the g

Pages (2): 1 2 Next
rektbyfaith
Administrator
0
09-27-2024, 01:38 PM
#1
Archived author: Revision • Posted: 2024-09-27T13:38:07.575000+00:00
Original source

I'm sorry but that doesn't even make sense. Add code to an existing project or rewrite it from the ground up - how is it faster to rewrite it?
rektbyfaith
09-27-2024, 01:38 PM #1

Archived author: Revision • Posted: 2024-09-27T13:38:07.575000+00:00
Original source

I'm sorry but that doesn't even make sense. Add code to an existing project or rewrite it from the ground up - how is it faster to rewrite it?

rektbyfaith
Administrator
0
09-27-2024, 01:39 PM
#2
Archived author: Revision • Posted: 2024-09-27T13:39:32.338000+00:00
Original source

Please do explain that one too. You're not eligible for writing code for other modules? What does that mean? Why wouldn't you be? *Most* repos welcome pull requests and will usually accept them if they fit in with the rest of the code, so why are you somehow, magically, blocked from creating pull requests?
rektbyfaith
09-27-2024, 01:39 PM #2

Archived author: Revision • Posted: 2024-09-27T13:39:32.338000+00:00
Original source

Please do explain that one too. You're not eligible for writing code for other modules? What does that mean? Why wouldn't you be? *Most* repos welcome pull requests and will usually accept them if they fit in with the rest of the code, so why are you somehow, magically, blocked from creating pull requests?

rektbyfaith
Administrator
0
09-27-2024, 01:39 PM
#3
Archived author: Rymercyble • Posted: 2024-09-27T13:39:53.586000+00:00
Original source

generally if system is too "legacy" its faster and simpler to rewrite it
rektbyfaith
09-27-2024, 01:39 PM #3

Archived author: Rymercyble • Posted: 2024-09-27T13:39:53.586000+00:00
Original source

generally if system is too "legacy" its faster and simpler to rewrite it

rektbyfaith
Administrator
0
09-27-2024, 01:40 PM
#4
Archived author: Revision • Posted: 2024-09-27T13:40:24.202000+00:00
Original source

Yes but in this case they want to "fix" the "gap" after TBC and to WotLK, how is it faster to rewrite the entire thing for that if pre-WotLK isn't broken?
rektbyfaith
09-27-2024, 01:40 PM #4

Archived author: Revision • Posted: 2024-09-27T13:40:24.202000+00:00
Original source

Yes but in this case they want to "fix" the "gap" after TBC and to WotLK, how is it faster to rewrite the entire thing for that if pre-WotLK isn't broken?

rektbyfaith
Administrator
0
09-27-2024, 01:41 PM
#5
Archived author: Revision • Posted: 2024-09-27T13:41:20.410000+00:00
Original source

I'm not against writing your own, we've all been there and even I have written several modules because I wasn't pleased with the ones available, but their reasoning for it is kind of weird.
rektbyfaith
09-27-2024, 01:41 PM #5

Archived author: Revision • Posted: 2024-09-27T13:41:20.410000+00:00
Original source

I'm not against writing your own, we've all been there and even I have written several modules because I wasn't pleased with the ones available, but their reasoning for it is kind of weird.

rektbyfaith
Administrator
0
09-27-2024, 01:41 PM
#6
Archived author: Geo • Posted: 2024-09-27T13:41:56.854000+00:00
Original source

Yeah even just using the existing module as a rough outline is easier than a straight rewrite
rektbyfaith
09-27-2024, 01:41 PM #6

Archived author: Geo • Posted: 2024-09-27T13:41:56.854000+00:00
Original source

Yeah even just using the existing module as a rough outline is easier than a straight rewrite

rektbyfaith
Administrator
0
09-27-2024, 01:42 PM
#7
Archived author: Geo • Posted: 2024-09-27T13:42:48.496000+00:00
Original source

Well, I guess that still qualifies as a "rewrite" but you get what I mean
rektbyfaith
09-27-2024, 01:42 PM #7

Archived author: Geo • Posted: 2024-09-27T13:42:48.496000+00:00
Original source

Well, I guess that still qualifies as a "rewrite" but you get what I mean

rektbyfaith
Administrator
0
09-27-2024, 02:16 PM
#8
Archived author: JEDI • Posted: 2024-09-27T14:16:29.393000+00:00
Original source

The existing module simply disabled the entry of some maps, also deleted some items from the vendors which are related to patch 3.0 onward, changed a lot on spells, creatures, items, etc. Despite that's not a 1:1 change, but to fix the gap, we need to 'undo the changes, which means there are too many to fix as they were changed to fit TBC.
rektbyfaith
09-27-2024, 02:16 PM #8

Archived author: JEDI • Posted: 2024-09-27T14:16:29.393000+00:00
Original source

The existing module simply disabled the entry of some maps, also deleted some items from the vendors which are related to patch 3.0 onward, changed a lot on spells, creatures, items, etc. Despite that's not a 1:1 change, but to fix the gap, we need to 'undo the changes, which means there are too many to fix as they were changed to fit TBC.

rektbyfaith
Administrator
0
09-27-2024, 02:18 PM
#9
Archived author: JEDI • Posted: 2024-09-27T14:18:35.239000+00:00
Original source

Starting a new project, in the other hand, just need to disable what we need for 3.0, then add everything back onwards.
rektbyfaith
09-27-2024, 02:18 PM #9

Archived author: JEDI • Posted: 2024-09-27T14:18:35.239000+00:00
Original source

Starting a new project, in the other hand, just need to disable what we need for 3.0, then add everything back onwards.

rektbyfaith
Administrator
0
09-27-2024, 02:25 PM
#10
Archived author: JEDI • Posted: 2024-09-27T14:25:48.325000+00:00
Original source

As my code may needs further support and update from the owner of the module, but they don't have time for this and it is not reasonable for me to ask them update the module. They are not get paid, and they have their own plan which I'm not the right person to push that. However I do need a workable script for my server asap, so I'm not eligible for updating that repo at this stage.
rektbyfaith
09-27-2024, 02:25 PM #10

Archived author: JEDI • Posted: 2024-09-27T14:25:48.325000+00:00
Original source

As my code may needs further support and update from the owner of the module, but they don't have time for this and it is not reasonable for me to ask them update the module. They are not get paid, and they have their own plan which I'm not the right person to push that. However I do need a workable script for my server asap, so I'm not eligible for updating that repo at this stage.

Pages (2): 1 2 Next
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)