[DiscordArchive] I updated azerothcore + modules today and in every updated module + core funtions, while compiling,
[DiscordArchive] I updated azerothcore + modules today and in every updated module + core funtions, while compiling,
Original source
I updated azerothcore + modules today and in every updated module + core funtions, while compiling, I see this:
`/home/user/azerothcore-wotlk/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/instance_trial_of_the_crusader.cpp:121:60: fatal error: use of undeclared identifier 'BIND_WHEN_EQUIPED'; did you mean 'BIND_WHEN_EQUIPPED'?
if (item->ItemLevel == 245 && item->Bonding == BIND_WHEN_EQUIPED) // this also includes items crafted from patterns obtained in ToC 10 norm/hc`
Why is this happening in so many places now?
rektbyfaith
09-02-2024, 12:42 PM #1Archived author: Iraluna • Posted: 2024-09-02T12:42:57.240000+00:00
Original source
I updated azerothcore + modules today and in every updated module + core funtions, while compiling, I see this:
`/home/user/azerothcore-wotlk/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/instance_trial_of_the_crusader.cpp:121:60: fatal error: use of undeclared identifier 'BIND_WHEN_EQUIPED'; did you mean 'BIND_WHEN_EQUIPPED'?
if (item->ItemLevel == 245 && item->Bonding == BIND_WHEN_EQUIPED) // this also includes items crafted from patterns obtained in ToC 10 norm/hc`
Why is this happening in so many places now?
Original source
The enumeration for `BIND_WHEN_EQUIPED` was changed to `BIND_WHEN_EQUIPPED`, I'd understand why it gives errors in modules, but doing a ctrl+f in the core shows no results for `equiped`, so I don't know why you'd be getting it there
rektbyfaith
09-02-2024, 12:44 PM #2Archived author: Bench • Posted: 2024-09-02T12:44:44.026000+00:00
Original source
The enumeration for `BIND_WHEN_EQUIPED` was changed to `BIND_WHEN_EQUIPPED`, I'd understand why it gives errors in modules, but doing a ctrl+f in the core shows no results for `equiped`, so I don't know why you'd be getting it there
Original source
I'd just do a `sed -i 's/foo/bar/g' *` in the azeroth-main-directory, that should fix it. Errors in modules are stuff that happens, but this one really was interesting.
rektbyfaith
09-02-2024, 12:46 PM #3Archived author: Iraluna • Posted: 2024-09-02T12:46:20.272000+00:00
Original source
I'd just do a `sed -i 's/foo/bar/g' *` in the azeroth-main-directory, that should fix it. Errors in modules are stuff that happens, but this one really was interesting.
Original source
What you fail to mention is that you're not using the official AC source where that was changed. As an example the playerbots core is behind so unless you update it yourself you'll get a few errors. Not just BIND_WHEN_EQUIPPED.
rektbyfaith
09-02-2024, 12:47 PM #4Archived author: Revision • Posted: 2024-09-02T12:47:44.151000+00:00
Original source
What you fail to mention is that you're not using the official AC source where that was changed. As an example the playerbots core is behind so unless you update it yourself you'll get a few errors. Not just BIND_WHEN_EQUIPPED.
Original source
then we will switch to playerbots-discord
rektbyfaith
09-02-2024, 12:48 PM #5Archived author: Iraluna • Posted: 2024-09-02T12:48:21.768000+00:00
Original source
then we will switch to playerbots-discord
Original source
Well, we solved that yesterday for Sanctuary and the solution is in the main-support channel.
rektbyfaith
09-02-2024, 12:50 PM #6Archived author: Revision • Posted: 2024-09-02T12:50:24.521000+00:00
Original source
Well, we solved that yesterday for Sanctuary and the solution is in the main-support channel.
Original source
I am using the docker build version, which has a specific container for dbimports. I see it mounts the data folder but does not mount modules data folders. Is the structure for modules directory structure data/sql/db-(database) or is data/db-(database)?
I am having trouble tracking through how this works so sql scripts are automatically run on world server boot. So I am asking first to save a little time of tracking through the code.
rektbyfaith
09-02-2024, 01:10 PM #7Archived author: volek • Posted: 2024-09-02T13:10:37.594000+00:00
Original source
I am using the docker build version, which has a specific container for dbimports. I see it mounts the data folder but does not mount modules data folders. Is the structure for modules directory structure data/sql/db-(database) or is data/db-(database)?
I am having trouble tracking through how this works so sql scripts are automatically run on world server boot. So I am asking first to save a little time of tracking through the code.
Original source
I haven't looked any further into it from earlier, but someone mentioned that a module needs to be configured for an automatic import, otherwise you have to run your queries manually
rektbyfaith
09-02-2024, 01:12 PM #8Archived author: Agent • Posted: 2024-09-02T13:12:13.713000+00:00
Original source
I haven't looked any further into it from earlier, but someone mentioned that a module needs to be configured for an automatic import, otherwise you have to run your queries manually
Original source
Using the right structure is sufficient. Just compare it to a module that has working auto-import.
rektbyfaith
09-02-2024, 01:13 PM #9Archived author: Honey • Posted: 2024-09-02T13:13:36.306000+00:00
Original source
Using the right structure is sufficient. Just compare it to a module that has working auto-import.
Original source
Yeah, that's what I tried and dropped the tables to see if it would recreate then and it did not. It looks like application order for docker runs are mysql, client-data check, dbimport, auth, world. The dbimport runs updates when new sql changes are launched by core, but confused on if it also handles module sql installs/updates or if world server runs a binary script to do this on that container launch. If it is the dbimport container then the docket file would need to be updated to also copy the modules folder so the sql there is picked up and run.
rektbyfaith
09-02-2024, 01:18 PM #10Archived author: volek • Posted: 2024-09-02T13:18:05.618000+00:00
Original source
Yeah, that's what I tried and dropped the tables to see if it would recreate then and it did not. It looks like application order for docker runs are mysql, client-data check, dbimport, auth, world. The dbimport runs updates when new sql changes are launched by core, but confused on if it also handles module sql installs/updates or if world server runs a binary script to do this on that container launch. If it is the dbimport container then the docket file would need to be updated to also copy the modules folder so the sql there is picked up and run.