[DiscordArchive] Still got magic numbers but is this going to be an issue in spell script to check quest objective da
[DiscordArchive] Still got magic numbers but is this going to be an issue in spell script to check quest objective da
Original source
Still got magic numbers but is this going to be an issue in spell script to check quest objective data?
![[Image: image.png?ex=690c7898&is=690b2718&hm=762...4dbbfa964&]](https://cdn.discordapp.com/attachments/376457124726702080/1196219631757701210/image.png?ex=690c7898&is=690b2718&hm=7622ce83fee4d46aac3af7b91005136b6a878561567db73812cdcb04dbbfa964&)
rektbyfaith
01-14-2024, 10:29 PM #1Archived author: Malcrom • Posted: 2024-01-14T22:29:44.945000+00:00
Original source
Still got magic numbers but is this going to be an issue in spell script to check quest objective data?
Original source
you have to check GetCaster() before casting it to player
rektbyfaith
01-14-2024, 10:34 PM #2Archived author: Northstrider • Posted: 2024-01-14T22:34:59.179000+00:00
Original source
you have to check GetCaster() before casting it to player
Original source
i did
rektbyfaith
01-14-2024, 10:35 PM #3Archived author: Malcrom • Posted: 2024-01-14T22:35:49.199000+00:00
Original source
i did
Original source
you did GetCaster()->ToPlayer(); this can crash if GetCaster() returns nullptr
rektbyfaith
01-14-2024, 10:36 PM #4Archived author: Northstrider • Posted: 2024-01-14T22:36:26.360000+00:00
Original source
you did GetCaster()->ToPlayer(); this can crash if GetCaster() returns nullptr
Original source
if (!player || !target)
return;
rektbyfaith
01-14-2024, 10:36 PM #5Archived author: Malcrom • Posted: 2024-01-14T22:36:36.744000+00:00
Original source
if (!player || !target)
return;
Original source
read above
rektbyfaith
01-14-2024, 10:36 PM #6Archived author: Northstrider • Posted: 2024-01-14T22:36:41.667000+00:00
Original source
read above
Original source
he wants you to do a !caster
rektbyfaith
01-14-2024, 10:37 PM #7Archived author: Fabian • Posted: 2024-01-14T22:37:02.704000+00:00
Original source
he wants you to do a !caster
Original source
If you wanna go this route you can also do Object::ToPlayer(GetCaster())
rektbyfaith
01-14-2024, 10:37 PM #8Archived author: Northstrider • Posted: 2024-01-14T22:37:16.710000+00:00
Original source
If you wanna go this route you can also do Object::ToPlayer(GetCaster())
Original source
```cpp
Player* player = GetCaster()->ToPlayer();
Creature* target = GetTarget()->ToCreature();
if (!player || !target)
return;
```
rektbyfaith
01-14-2024, 10:37 PM #9Archived author: Malcrom • Posted: 2024-01-14T22:37:52.737000+00:00
Original source
```cpp
Player* player = GetCaster()->ToPlayer();
Creature* target = GetTarget()->ToCreature();
if (!player || !target)
return;
```
Original source
so thats not safe?
rektbyfaith
01-14-2024, 10:37 PM #10Archived author: Malcrom • Posted: 2024-01-14T22:37:58.876000+00:00
Original source
so thats not safe?
1 Guest(s)
1 Guest(s)