[DiscordArchive] I've noticed something strange when looting item boxes I wonder if it's the same on master branch?
[DiscordArchive] I've noticed something strange when looting item boxes I wonder if it's the same on master branch?
Original source
we are talking about worldServerInfo.InstanceGroupSize
rektbyfaith
01-29-2024, 03:36 PM #21Archived author: Northstrider • Posted: 2024-01-29T15:36:38.986000+00:00
Original source
we are talking about worldServerInfo.InstanceGroupSize
Original source
which is an optional field and it's not set
rektbyfaith
01-29-2024, 03:36 PM #22Archived author: Northstrider • Posted: 2024-01-29T15:36:46.479000+00:00
Original source
which is an optional field and it's not set
Original source
so not even blizzard uses mapdifficulty data here
rektbyfaith
01-29-2024, 03:37 PM #23Archived author: Northstrider • Posted: 2024-01-29T15:37:06.585000+00:00
Original source
so not even blizzard uses mapdifficulty data here
Original source
```
if (MapDifficultyEntry const* mapDifficulty = GetMap()->GetMapDifficulty())
worldServerInfo.InstanceGroupSize = mapDifficulty->MaxPlayers;
```
so we gotta use this check.
rektbyfaith
01-29-2024, 03:37 PM #24Archived author: Northstrider • Posted: 2024-01-29T15:37:42.226000+00:00
Original source
```
if (MapDifficultyEntry const* mapDifficulty = GetMap()->GetMapDifficulty())
worldServerInfo.InstanceGroupSize = mapDifficulty->MaxPlayers;
```
so we gotta use this check.
Original source
we can but the sniff shows that blizzard also does not give a fuck about this wrong mapdifficulty entry
rektbyfaith
01-29-2024, 03:38 PM #25Archived author: Northstrider • Posted: 2024-01-29T15:38:39.885000+00:00
Original source
we can but the sniff shows that blizzard also does not give a fuck about this wrong mapdifficulty entry
Original source
and just ignores it alltogether
rektbyfaith
01-29-2024, 03:38 PM #26Archived author: Northstrider • Posted: 2024-01-29T15:38:51.410000+00:00
Original source
and just ignores it alltogether
Original source
looks good to me since instanceGroupSize is optional and all
rektbyfaith
01-29-2024, 03:41 PM #27Archived author: Alistar • Posted: 2024-01-29T15:41:51.617000+00:00
Original source
looks good to me since instanceGroupSize is optional and all
Original source
![[Image: image.png?ex=690c1956&is=690ac7d6&hm=5da...f0b979ed2&]](https://cdn.discordapp.com/attachments/974733680192913478/1201553166848770220/image.png?ex=690c1956&is=690ac7d6&hm=5daf60678a3e778878f51b17acb27f93a348bd64a170fb4778881a4f0b979ed2&)
rektbyfaith
01-29-2024, 03:43 PM #28Archived author: Alistar • Posted: 2024-01-29T15:43:18.726000+00:00
Original source
Original source
will be cherrypicked into wotlk classic when funjoker does the next batch of cherrypicks
rektbyfaith
01-29-2024, 03:49 PM #29Archived author: Northstrider • Posted: 2024-01-29T15:49:45.500000+00:00
Original source
will be cherrypicked into wotlk classic when funjoker does the next batch of cherrypicks
Original source
<:zuckster:770403425115963392>
rektbyfaith
01-29-2024, 04:02 PM #30Archived author: funjoker • Posted: 2024-01-29T16:02:19.461000+00:00
Original source
<:zuckster:770403425115963392>