Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] <https://github.com/mdX7/wow-tools/commit/9558c08d03bbf35e462f0bf83c7265356d1ff9ac#diff-29f6bbb505af

[DiscordArchive] <https://github.com/mdX7/wow-tools/commit/9558c08d03bbf35e462f0bf83c7265356d1ff9ac#diff-29f6bbb505af

[DiscordArchive] <https://github.com/mdX7/wow-tools/commit/9558c08d03bbf35e462f0bf83c7265356d1ff9ac#diff-29f6bbb505af

rektbyfaith
Administrator
0
05-16-2022, 07:58 PM
#1
Archived author: Tea • Posted: 2022-05-16T19:58:54.240000+00:00
Original source

<https://github.com/mdX7/wow-tools/commit/9558c08d03bbf35e462f0bf83c7265356d1ff9ac#diff-29f6bbb505afd795a6195b8192650e7986956b72afda62532d2dbe0390cea120R103> lol really blizz?
rektbyfaith
05-16-2022, 07:58 PM #1

Archived author: Tea • Posted: 2022-05-16T19:58:54.240000+00:00
Original source

<https://github.com/mdX7/wow-tools/commit/9558c08d03bbf35e462f0bf83c7265356d1ff9ac#diff-29f6bbb505afd795a6195b8192650e7986956b72afda62532d2dbe0390cea120R103> lol really blizz?

rektbyfaith
Administrator
0
05-16-2022, 07:58 PM
#2
Archived author: Tea • Posted: 2022-05-16T19:58:58.029000+00:00
Original source

thats a mop feature
rektbyfaith
05-16-2022, 07:58 PM #2

Archived author: Tea • Posted: 2022-05-16T19:58:58.029000+00:00
Original source

thats a mop feature

rektbyfaith
Administrator
0
05-16-2022, 08:01 PM
#3
Archived author: ModoX • Posted: 2022-05-16T20:01:26.330000+00:00
Original source

apparently i forgot to fix optional in ConversationActor bcuz i wasn't able to figure out how it works <:kekw:707032773831163917>
rektbyfaith
05-16-2022, 08:01 PM #3

Archived author: ModoX • Posted: 2022-05-16T20:01:26.330000+00:00
Original source

apparently i forgot to fix optional in ConversationActor bcuz i wasn't able to figure out how it works <:kekw:707032773831163917>

rektbyfaith
Administrator
0
05-16-2022, 08:01 PM
#4
Archived author: ModoX • Posted: 2022-05-16T20:01:39.333000+00:00
Original source

```c
__int64 __fastcall ReadCreateConversationActor(unsigned __int8 *a1, __int64 a2)
{
__int64 result; // rax
int v5; // [rsp+30h] [rbp+8h] BYREF

LOBYTE(v5) = 0;
CDataStore::GetByte(a2, &v5);
*a1 = (unsigned __int8)v5 >> 7;
v5 = 0;
CDataStore::GetInt32(a2, &v5);
*((_DWORD *)a1 + 1) = v5;
if ( !*a1 )
return CDataStore::GetPackedGuid128(a2, a1 + 16);
v5 = 0;
CDataStore::GetUInt32(a2, &v5);
*((_DWORD *)a1 + 2) = v5;
v5 = 0;
CDataStore::GetUInt32(a2, &v5);
*((_DWORD *)a1 + 3) = v5;
result = *a1;
if ( !(_BYTE)result )
return CDataStore::GetPackedGuid128(a2, a1 + 16);
return result;
}
```
rektbyfaith
05-16-2022, 08:01 PM #4

Archived author: ModoX • Posted: 2022-05-16T20:01:39.333000+00:00
Original source

```c
__int64 __fastcall ReadCreateConversationActor(unsigned __int8 *a1, __int64 a2)
{
__int64 result; // rax
int v5; // [rsp+30h] [rbp+8h] BYREF

LOBYTE(v5) = 0;
CDataStore::GetByte(a2, &v5);
*a1 = (unsigned __int8)v5 >> 7;
v5 = 0;
CDataStore::GetInt32(a2, &v5);
*((_DWORD *)a1 + 1) = v5;
if ( !*a1 )
return CDataStore::GetPackedGuid128(a2, a1 + 16);
v5 = 0;
CDataStore::GetUInt32(a2, &v5);
*((_DWORD *)a1 + 2) = v5;
v5 = 0;
CDataStore::GetUInt32(a2, &v5);
*((_DWORD *)a1 + 3) = v5;
result = *a1;
if ( !(_BYTE)result )
return CDataStore::GetPackedGuid128(a2, a1 + 16);
return result;
}
```

rektbyfaith
Administrator
0
05-16-2022, 08:02 PM
#5
Archived author: ModoX • Posted: 2022-05-16T20:02:11.754000+00:00
Original source

i dont quite get how to define how the has_value() will be read in uf gen <@200677690838220800>
rektbyfaith
05-16-2022, 08:02 PM #5

Archived author: ModoX • Posted: 2022-05-16T20:02:11.754000+00:00
Original source

i dont quite get how to define how the has_value() will be read in uf gen <@200677690838220800>

rektbyfaith
Administrator
0
05-16-2022, 08:12 PM
#6
Archived author: Tea • Posted: 2022-05-16T20:12:30.844000+00:00
Original source

this isnt an optional
rektbyfaith
05-16-2022, 08:12 PM #6

Archived author: Tea • Posted: 2022-05-16T20:12:30.844000+00:00
Original source

this isnt an optional

rektbyfaith
Administrator
0
05-16-2022, 08:16 PM
#7
Archived author: Tea • Posted: 2022-05-16T20:16:36.782000+00:00
Original source

let me cleanup that function for you
rektbyfaith
05-16-2022, 08:16 PM #7

Archived author: Tea • Posted: 2022-05-16T20:16:36.782000+00:00
Original source

let me cleanup that function for you

rektbyfaith
Administrator
0
05-16-2022, 08:16 PM
#8
Archived author: Tea • Posted: 2022-05-16T20:16:39.441000+00:00
Original source

```
__int64 __fastcall ReadCreateConversationActor(unsigned __int8 *a1, __int64 a2)
{
CDataStore::GetByte(a2, &v5);
a1->Type = (unsigned __int8)v5 >> 7;
CDataStore::GetInt32(a2, &a1->Id);
switch (a1->Type)
{
case 0:
CDataStore::GetPackedGuid128(a2, &a1->ActorGUID);
break;
case 1:
CDataStore::GetUInt32(a2, &a1->CreatureID);
CDataStore::GetUInt32(a2, &a1->CreatureDisplayInfoID);
break;
}
}
```
rektbyfaith
05-16-2022, 08:16 PM #8

Archived author: Tea • Posted: 2022-05-16T20:16:39.441000+00:00
Original source

```
__int64 __fastcall ReadCreateConversationActor(unsigned __int8 *a1, __int64 a2)
{
CDataStore::GetByte(a2, &v5);
a1->Type = (unsigned __int8)v5 >> 7;
CDataStore::GetInt32(a2, &a1->Id);
switch (a1->Type)
{
case 0:
CDataStore::GetPackedGuid128(a2, &a1->ActorGUID);
break;
case 1:
CDataStore::GetUInt32(a2, &a1->CreatureID);
CDataStore::GetUInt32(a2, &a1->CreatureDisplayInfoID);
break;
}
}
```

rektbyfaith
Administrator
0
05-16-2022, 08:19 PM
#9
Archived author: ModoX • Posted: 2022-05-16T20:19:44.593000+00:00
Original source

oh i missed that return <:face_palm:770403425191723009>
rektbyfaith
05-16-2022, 08:19 PM #9

Archived author: ModoX • Posted: 2022-05-16T20:19:44.593000+00:00
Original source

oh i missed that return <:face_palm:770403425191723009>

rektbyfaith
Administrator
0
05-16-2022, 08:20 PM
#10
Archived author: Tea • Posted: 2022-05-16T20:20:56.291000+00:00
Original source

thats really interesting, none of master versions of conversation actor used this structure... except pre-updatefield-rewrite
rektbyfaith
05-16-2022, 08:20 PM #10

Archived author: Tea • Posted: 2022-05-16T20:20:56.291000+00:00
Original source

thats really interesting, none of master versions of conversation actor used this structure... except pre-updatefield-rewrite

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)