Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] Can someone explain why we even need `Spell::HandleThreatSpells`? Where can I find info about `Spell

[DiscordArchive] Can someone explain why we even need `Spell::HandleThreatSpells`? Where can I find info about `Spell

[DiscordArchive] Can someone explain why we even need `Spell::HandleThreatSpells`? Where can I find info about `Spell

rektbyfaith
Administrator
0
06-29-2024, 10:04 PM
#1
Archived author: r4dish • Posted: 2024-06-29T22:04:24.648000+00:00
Original source

Can someone explain why we even need `Spell::HandleThreatSpells`? Where can I find info about `SpellLevel` should added to generated threat, wtf?
rektbyfaith
06-29-2024, 10:04 PM #1

Archived author: r4dish • Posted: 2024-06-29T22:04:24.648000+00:00
Original source

Can someone explain why we even need `Spell::HandleThreatSpells`? Where can I find info about `SpellLevel` should added to generated threat, wtf?

rektbyfaith
Administrator
0
06-29-2024, 10:06 PM
#2
Archived author: r4dish • Posted: 2024-06-29T22:06:19.239000+00:00
Original source

https://github.com/TrinityCore/TrinityCo....cpp#L5754
rektbyfaith
06-29-2024, 10:06 PM #2

Archived author: r4dish • Posted: 2024-06-29T22:06:19.239000+00:00
Original source

https://github.com/TrinityCore/TrinityCo....cpp#L5754

rektbyfaith
Administrator
0
06-29-2024, 10:12 PM
#3
Archived author: Northstrider • Posted: 2024-06-29T22:12:15.111000+00:00
Original source

spell level is used to scale the basepoints in certain scenarios. so SpellEffectInfo::CalcValue is your stop. the effect handler does only handle the final value
rektbyfaith
06-29-2024, 10:12 PM #3

Archived author: Northstrider • Posted: 2024-06-29T22:12:15.111000+00:00
Original source

spell level is used to scale the basepoints in certain scenarios. so SpellEffectInfo::CalcValue is your stop. the effect handler does only handle the final value

rektbyfaith
Administrator
0
06-29-2024, 10:23 PM
#4
Archived author: r4dish • Posted: 2024-06-29T22:23:16.054000+00:00
Original source

I mean, why do we even need this function? Threat is calculated and added based on the damage dealt in `Unit:Big GrinealDamage`, and also based on the healing done in `Spell::TargetInfo:Big GrinoDamageAndTriggers`. Why do we need to add SpellLevel to the threat level at all? It's strange
rektbyfaith
06-29-2024, 10:23 PM #4

Archived author: r4dish • Posted: 2024-06-29T22:23:16.054000+00:00
Original source

I mean, why do we even need this function? Threat is calculated and added based on the damage dealt in `Unit:Big GrinealDamage`, and also based on the healing done in `Spell::TargetInfo:Big GrinoDamageAndTriggers`. Why do we need to add SpellLevel to the threat level at all? It's strange

rektbyfaith
Administrator
0
06-29-2024, 10:25 PM
#5
Archived author: Northstrider • Posted: 2024-06-29T22:25:51.624000+00:00
Original source

there are spells with extra threat effects, such as fake taunts used by adds
rektbyfaith
06-29-2024, 10:25 PM #5

Archived author: Northstrider • Posted: 2024-06-29T22:25:51.624000+00:00
Original source

there are spells with extra threat effects, such as fake taunts used by adds

rektbyfaith
Administrator
0
06-29-2024, 10:25 PM
#6
Archived author: Northstrider • Posted: 2024-06-29T22:25:56.332000+00:00
Original source

or pet growl
rektbyfaith
06-29-2024, 10:25 PM #6

Archived author: Northstrider • Posted: 2024-06-29T22:25:56.332000+00:00
Original source

or pet growl

rektbyfaith
Administrator
0
06-29-2024, 10:26 PM
#7
Archived author: r4dish • Posted: 2024-06-29T22:26:52.950000+00:00
Original source

No, this function is called for absolutely all spells, right inside `Spell::_handle_immediate_phase`
rektbyfaith
06-29-2024, 10:26 PM #7

Archived author: r4dish • Posted: 2024-06-29T22:26:52.950000+00:00
Original source

No, this function is called for absolutely all spells, right inside `Spell::_handle_immediate_phase`

rektbyfaith
Administrator
0
06-29-2024, 10:27 PM
#8
Archived author: Gamemechanic • Posted: 2024-06-29T22:27:08.514000+00:00
Original source

and what does it do? ...
rektbyfaith
06-29-2024, 10:27 PM #8

Archived author: Gamemechanic • Posted: 2024-06-29T22:27:08.514000+00:00
Original source

and what does it do? ...

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)