[DiscordArchive] yo <@200677690838220800> u fine if I push https://github.com/Ovahlord/TrinityCore/commit/30f2d9ca3
[DiscordArchive] yo <@200677690838220800> u fine if I push https://github.com/Ovahlord/TrinityCore/commit/30f2d9ca3
Original source
yo <@200677690838220800> u fine if I push https://github.com/Ovahlord/TrinityCore/...e38d596709 into all branches?
[Embed: Core/Players: cleaned up resurrection code a bit and clear resurrec...]
…on requests after accepting them
https://github.com/Ovahlord/TrinityCore/...e38d596709
rektbyfaith
01-30-2024, 11:42 AM #1Archived author: Northstrider • Posted: 2024-01-30T11:42:54.138000+00:00
Original source
yo <@200677690838220800> u fine if I push https://github.com/Ovahlord/TrinityCore/...e38d596709 into all branches?
[Embed: Core/Players: cleaned up resurrection code a bit and clear resurrec...]
…on requests after accepting them
https://github.com/Ovahlord/TrinityCore/...e38d596709
Original source
this should fix the packet spoofing exploit
rektbyfaith
01-30-2024, 11:45 AM #2Archived author: Northstrider • Posted: 2024-01-30T11:45:37.913000+00:00
Original source
this should fix the packet spoofing exploit
Original source
first of all no, this breaks resurrecting (inverted logic)
rektbyfaith
01-30-2024, 11:45 AM #3Archived author: Tea • Posted: 2024-01-30T11:45:44.875000+00:00
Original source
first of all no, this breaks resurrecting (inverted logic)
Original source
huh? player requests to resurrect a target. target accepts or rejects the request --> clear request or resurrect and then clear request
rektbyfaith
01-30-2024, 11:46 AM #4Archived author: Northstrider • Posted: 2024-01-30T11:46:30.440000+00:00
Original source
huh? player requests to resurrect a target. target accepts or rejects the request --> clear request or resurrect and then clear request
Original source
old:
rektbyfaith
01-30-2024, 11:46 AM #5Archived author: Tea • Posted: 2024-01-30T11:46:48.120000+00:00
Original source
old:
Original source
Well it was only an accident, I was implementing the rez static popup in my custom client and it accidentally sent both accept and decline CMSG_RESURRECT_RESPONSE at the same time lol. Just abit of random luck finding that issue happy it can potentially help TC because TC is very important to me <:owocat:486485371849277451>
rektbyfaith
01-30-2024, 11:47 AM #6Archived author: HelloKitty • Posted: 2024-01-30T11:47:01.706000+00:00
Original source
Well it was only an accident, I was implementing the rez static popup in my custom client and it accidentally sent both accept and decline CMSG_RESURRECT_RESPONSE at the same time lol. Just abit of random luck finding that issue happy it can potentially help TC because TC is very important to me <:owocat:486485371849277451>
Original source
```
if (!GetPlayer()->IsResurrectRequestedBy(packet.Resurrecter))
return;
```
new:
```
if (GetPlayer()->IsResurrectRequestedBy(packet.Resurrecter))
return;
```
rektbyfaith
01-30-2024, 11:47 AM #7Archived author: Tea • Posted: 2024-01-30T11:47:03.095000+00:00
Original source
```
if (!GetPlayer()->IsResurrectRequestedBy(packet.Resurrecter))
return;
```
new:
```
if (GetPlayer()->IsResurrectRequestedBy(packet.Resurrecter))
return;
```
Original source
ah thanks. yeah, oversight
rektbyfaith
01-30-2024, 11:47 AM #8Archived author: Northstrider • Posted: 2024-01-30T11:47:29.753000+00:00
Original source
ah thanks. yeah, oversight
Original source
the cleanup of the smart ptr handling is fine?
rektbyfaith
01-30-2024, 11:48 AM #9Archived author: Northstrider • Posted: 2024-01-30T11:48:17.460000+00:00
Original source
the cleanup of the smart ptr handling is fine?
1 Guest(s)
1 Guest(s)