Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] is `MapManager::FindBaseMap` just hands in the air unsafe or am I missing something here? The map lo

[DiscordArchive] is `MapManager::FindBaseMap` just hands in the air unsafe or am I missing something here? The map lo

[DiscordArchive] is `MapManager::FindBaseMap` just hands in the air unsafe or am I missing something here? The map lo

rektbyfaith
Administrator
0
11-08-2021, 01:18 PM
#1
Archived author: <o> • Posted: 2021-11-08T13:18:42.054000+00:00
Original source

is `MapManager::FindBaseMap` just hands in the air unsafe or am I missing something here? The map lock is only actually applied for inserts, but `std::unordered_map` isn't threadsafe to read/write concurrently at all. Since we do plenty of base map inserts outside of initialization, what's going on here?
rektbyfaith
11-08-2021, 01:18 PM #1

Archived author: <o> • Posted: 2021-11-08T13:18:42.054000+00:00
Original source

is `MapManager::FindBaseMap` just hands in the air unsafe or am I missing something here? The map lock is only actually applied for inserts, but `std::unordered_map` isn't threadsafe to read/write concurrently at all. Since we do plenty of base map inserts outside of initialization, what's going on here?

rektbyfaith
Administrator
0
11-08-2021, 01:34 PM
#2
Archived author: Tea • Posted: 2021-11-08T13:34:02.810000+00:00
Original source

you are probably missing the overall threading situation in TC
rektbyfaith
11-08-2021, 01:34 PM #2

Archived author: Tea • Posted: 2021-11-08T13:34:02.810000+00:00
Original source

you are probably missing the overall threading situation in TC

rektbyfaith
Administrator
0
11-08-2021, 01:40 PM
#3
Archived author: <o> • Posted: 2021-11-08T13:40:04.584000+00:00
Original source

thanks, i'll spend some more time
rektbyfaith
11-08-2021, 01:40 PM #3

Archived author: <o> • Posted: 2021-11-08T13:40:04.584000+00:00
Original source

thanks, i'll spend some more time

rektbyfaith
Administrator
0
11-08-2021, 01:40 PM
#4
Archived author: Tea • Posted: 2021-11-08T13:40:48.627000+00:00
Original source

maps should not be created outside of main thread
rektbyfaith
11-08-2021, 01:40 PM #4

Archived author: Tea • Posted: 2021-11-08T13:40:48.627000+00:00
Original source

maps should not be created outside of main thread

rektbyfaith
Administrator
0
11-08-2021, 01:51 PM
#5
Archived author: <o> • Posted: 2021-11-08T13:51:36.394000+00:00
Original source

yeah i see it now, I was looking at the Transport spawning one but missed the really big text right above it saying `Transport:Big GrinELAYEDTeleport...`
rektbyfaith
11-08-2021, 01:51 PM #5

Archived author: <o> • Posted: 2021-11-08T13:51:36.394000+00:00
Original source

yeah i see it now, I was looking at the Transport spawning one but missed the really big text right above it saying `Transport:Big GrinELAYEDTeleport...`

rektbyfaith
Administrator
0
11-08-2021, 01:51 PM
#6
Archived author: <o> • Posted: 2021-11-08T13:51:51.585000+00:00
Original source

thanks, somehow got the impression it kept doing this in the normal map updates
rektbyfaith
11-08-2021, 01:51 PM #6

Archived author: <o> • Posted: 2021-11-08T13:51:51.585000+00:00
Original source

thanks, somehow got the impression it kept doing this in the normal map updates

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)