Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] PR?

[DiscordArchive] PR?

[DiscordArchive] PR?

Pages (4): Previous 1 2 3 4 Next
rektbyfaith
Administrator
0
08-24-2025, 07:07 AM
#11
Archived author: DioHun • Posted: 2025-08-24T07:07:56.336000+00:00
Original source

i mean the next commit, just i write pr from that, but nobody accepted. so now that in this commit.
rektbyfaith
08-24-2025, 07:07 AM #11

Archived author: DioHun • Posted: 2025-08-24T07:07:56.336000+00:00
Original source

i mean the next commit, just i write pr from that, but nobody accepted. so now that in this commit.

rektbyfaith
Administrator
0
08-24-2025, 07:09 AM
#12
Archived author: MaxtorCoder • Posted: 2025-08-24T07:09:22.132000+00:00
Original source

Or just wait for the other PR to be merged
rektbyfaith
08-24-2025, 07:09 AM #12

Archived author: MaxtorCoder • Posted: 2025-08-24T07:09:22.132000+00:00
Original source

Or just wait for the other PR to be merged

rektbyfaith
Administrator
0
08-24-2025, 07:09 AM
#13
Archived author: MaxtorCoder • Posted: 2025-08-24T07:09:29.845000+00:00
Original source

If the code is not needed for that specific feature, don't add it
rektbyfaith
08-24-2025, 07:09 AM #13

Archived author: MaxtorCoder • Posted: 2025-08-24T07:09:29.845000+00:00
Original source

If the code is not needed for that specific feature, don't add it

rektbyfaith
Administrator
0
08-24-2025, 07:19 AM
#14
Archived author: Tea • Posted: 2025-08-24T07:19:20.864000+00:00
Original source

seriously, dont just dump all your work into 1 branch
rektbyfaith
08-24-2025, 07:19 AM #14

Archived author: Tea • Posted: 2025-08-24T07:19:20.864000+00:00
Original source

seriously, dont just dump all your work into 1 branch

rektbyfaith
Administrator
0
08-24-2025, 07:20 AM
#15
Archived author: DioHun • Posted: 2025-08-24T07:20:01.481000+00:00
Original source

yeah i know. but that commit good.
rektbyfaith
08-24-2025, 07:20 AM #15

Archived author: DioHun • Posted: 2025-08-24T07:20:01.481000+00:00
Original source

yeah i know. but that commit good.

rektbyfaith
Administrator
0
08-24-2025, 07:20 AM
#16
Archived author: DioHun • Posted: 2025-08-24T07:20:48.698000+00:00
Original source

just accept it, and all ppl happy
rektbyfaith
08-24-2025, 07:20 AM #16

Archived author: DioHun • Posted: 2025-08-24T07:20:48.698000+00:00
Original source

just accept it, and all ppl happy

rektbyfaith
Administrator
0
08-24-2025, 07:21 AM
#17
Archived author: ModoX • Posted: 2025-08-24T07:21:03.869000+00:00
Original source

"Trust me bro"
rektbyfaith
08-24-2025, 07:21 AM #17

Archived author: ModoX • Posted: 2025-08-24T07:21:03.869000+00:00
Original source

"Trust me bro"

rektbyfaith
Administrator
0
08-24-2025, 07:22 AM
#18
Archived author: ModoX • Posted: 2025-08-24T07:22:08.554000+00:00
Original source

Code has to be reviewed anyway, even if it "works", maybe there is room for improvements or even performance impacts or possible crashes that have to be addressed
rektbyfaith
08-24-2025, 07:22 AM #18

Archived author: ModoX • Posted: 2025-08-24T07:22:08.554000+00:00
Original source

Code has to be reviewed anyway, even if it "works", maybe there is room for improvements or even performance impacts or possible crashes that have to be addressed

rektbyfaith
Administrator
0
08-24-2025, 07:22 AM
#19
Archived author: DioHun • Posted: 2025-08-24T07:22:24.738000+00:00
Original source

I'll pay more attention next time.
rektbyfaith
08-24-2025, 07:22 AM #19

Archived author: DioHun • Posted: 2025-08-24T07:22:24.738000+00:00
Original source

I'll pay more attention next time.

rektbyfaith
Administrator
0
08-24-2025, 07:22 AM
#20
Archived author: ModoX • Posted: 2025-08-24T07:22:32.102000+00:00
Original source

rektbyfaith
08-24-2025, 07:22 AM #20

Archived author: ModoX • Posted: 2025-08-24T07:22:32.102000+00:00
Original source

Pages (4): Previous 1 2 3 4 Next
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)