Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] https://github.com/TrinityCore/TrinityCore/commit/d808e78702624a11431fed5ff365584bc908d9a5

[DiscordArchive] https://github.com/TrinityCore/TrinityCore/commit/d808e78702624a11431fed5ff365584bc908d9a5

[DiscordArchive] https://github.com/TrinityCore/TrinityCore/commit/d808e78702624a11431fed5ff365584bc908d9a5

rektbyfaith
Administrator
0
03-19-2024, 01:00 PM
#1
Archived author: Kelno • Posted: 2024-03-19T13:00:32.196000+00:00
Original source

https://github.com/TrinityCore/TrinityCo...4bc908d9a5
Looks correct to you?
[Embed: Fixed memory leak in CliCommandHolder constructor · TrinityCore/Tri...]
strdup is not needed here, std:Confusedtring constructor will copy the data already.
https://github.com/TrinityCore/TrinityCo...4bc908d9a5
rektbyfaith
03-19-2024, 01:00 PM #1

Archived author: Kelno • Posted: 2024-03-19T13:00:32.196000+00:00
Original source

https://github.com/TrinityCore/TrinityCo...4bc908d9a5
Looks correct to you?
[Embed: Fixed memory leak in CliCommandHolder constructor · TrinityCore/Tri...]
strdup is not needed here, std:Confusedtring constructor will copy the data already.
https://github.com/TrinityCore/TrinityCo...4bc908d9a5

rektbyfaith
Administrator
0
03-19-2024, 01:11 PM
#2
Archived author: Tea • Posted: 2024-03-19T13:11:23.146000+00:00
Original source

what? no
rektbyfaith
03-19-2024, 01:11 PM #2

Archived author: Tea • Posted: 2024-03-19T13:11:23.146000+00:00
Original source

what? no

rektbyfaith
Administrator
0
03-19-2024, 01:12 PM
#3
Archived author: Tea • Posted: 2024-03-19T13:12:33.836000+00:00
Original source

m_command is a char*, not std:Confusedtring
rektbyfaith
03-19-2024, 01:12 PM #3

Archived author: Tea • Posted: 2024-03-19T13:12:33.836000+00:00
Original source

m_command is a char*, not std:Confusedtring

rektbyfaith
Administrator
0
03-19-2024, 01:12 PM
#4
Archived author: Tea • Posted: 2024-03-19T13:12:55.983000+00:00
Original source

and has correct free() in destructor
rektbyfaith
03-19-2024, 01:12 PM #4

Archived author: Tea • Posted: 2024-03-19T13:12:55.983000+00:00
Original source

and has correct free() in destructor

rektbyfaith
Administrator
0
03-19-2024, 01:13 PM
#5
Archived author: Tea • Posted: 2024-03-19T13:13:15.239000+00:00
Original source

there is no leak at all here
rektbyfaith
03-19-2024, 01:13 PM #5

Archived author: Tea • Posted: 2024-03-19T13:13:15.239000+00:00
Original source

there is no leak at all here

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)