Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] Do you have a crashlog ?

[DiscordArchive] Do you have a crashlog ?

[DiscordArchive] Do you have a crashlog ?

rektbyfaith
Administrator
Find
0
01-31-2023, 10:25 PM
#1
Archived author: jackpoz • Posted: 2024-06-25T20:37:13.932000+00:00
Original source

do you have a crashlog ?
Reply
Reply
rektbyfaith
01-31-2023, 10:25 PM #1

Archived author: jackpoz • Posted: 2024-06-25T20:37:13.932000+00:00
Original source

do you have a crashlog ?

Reply
Reply
rektbyfaith
Administrator
Find
0
01-31-2023, 10:58 PM
#2
Archived author: Deleted User • Posted: 2023-01-31T22:58:04.183000+00:00
Original source

I fixed it, crash was because I forgot to change a line from the diff
```diff
- return m_bgData.bgTeam ? m_bgData.bgTeam : GetTeam();
+ return m_bgData.bgTeam ? m_bgData.bgTeam : m_team;
```
Reply
Reply
rektbyfaith
01-31-2023, 10:58 PM #2

Archived author: Deleted User • Posted: 2023-01-31T22:58:04.183000+00:00
Original source

I fixed it, crash was because I forgot to change a line from the diff
```diff
- return m_bgData.bgTeam ? m_bgData.bgTeam : GetTeam();
+ return m_bgData.bgTeam ? m_bgData.bgTeam : m_team;
```

Reply
Reply
rektbyfaith
Administrator
Find
0
01-31-2023, 10:58 PM
#3
Archived author: Deleted User • Posted: 2023-01-31T22:58:15.084000+00:00
Original source

Still, the script does not work
Reply
Reply
rektbyfaith
01-31-2023, 10:58 PM #3

Archived author: Deleted User • Posted: 2023-01-31T22:58:15.084000+00:00
Original source

Still, the script does not work

Reply
Reply
rektbyfaith
Administrator
Find
0
01-31-2023, 10:58 PM
#4
Archived author: Deleted User • Posted: 2023-01-31T22:58:30.389000+00:00
Original source

https://github.com/TrinityCore/TrinityCo.../issues/64 this is happening
Reply
Reply
rektbyfaith
01-31-2023, 10:58 PM #4

Archived author: Deleted User • Posted: 2023-01-31T22:58:30.389000+00:00
Original source

https://github.com/TrinityCore/TrinityCo.../issues/64 this is happening

Reply
Reply
rektbyfaith
Administrator
Find
0
01-31-2023, 11:26 PM
#5
Archived author: Deleted User • Posted: 2023-01-31T23:26:41.462000+00:00
Original source

Well I found some 'fixes' Im open to share them if anyone cares. I do not have git account to open an issue request or however is it called
Reply
Reply
rektbyfaith
01-31-2023, 11:26 PM #5

Archived author: Deleted User • Posted: 2023-01-31T23:26:41.462000+00:00
Original source

Well I found some 'fixes' Im open to share them if anyone cares. I do not have git account to open an issue request or however is it called

Reply
Reply
rektbyfaith
Administrator
Find
0
01-31-2023, 11:29 PM
#6
Archived author: Deleted User • Posted: 2023-01-31T23:29:25.658000+00:00
Original source

On function from `CrossfactionBattlegrounds.cpp` it seems the dev wanted to 'reapply' the fake display race in case of players re-loggin inside battleground
`void OnLogin(Player* player, bool /*firstLogin*/)`
So a simple return after checking the actual map would fix a 'bug' where players would login (into world, not a bg or arena map) and having a fake race display id
```if (!player->GetMap()->IsBattlegroundOrArena())
return;```
So the function would end like this:
```
void OnLogin(Player* player, bool /*firstLogin*/) override
{
if (!player->GetMap()->IsBattlegroundOrArena())
return;

if (!player->cfbgdata->NativeTeam())
{
player->SetRace(player->cfbgdata->GetFRace());
player->SetFactionForRace(player->GetRace());
player->cfbgdata->SetRaceDisplayID();
}
}
```
(The dev didn't override, I did tho).
Reply
Reply
rektbyfaith
01-31-2023, 11:29 PM #6

Archived author: Deleted User • Posted: 2023-01-31T23:29:25.658000+00:00
Original source

On function from `CrossfactionBattlegrounds.cpp` it seems the dev wanted to 'reapply' the fake display race in case of players re-loggin inside battleground
`void OnLogin(Player* player, bool /*firstLogin*/)`
So a simple return after checking the actual map would fix a 'bug' where players would login (into world, not a bg or arena map) and having a fake race display id
```if (!player->GetMap()->IsBattlegroundOrArena())
return;```
So the function would end like this:
```
void OnLogin(Player* player, bool /*firstLogin*/) override
{
if (!player->GetMap()->IsBattlegroundOrArena())
return;

if (!player->cfbgdata->NativeTeam())
{
player->SetRace(player->cfbgdata->GetFRace());
player->SetFactionForRace(player->GetRace());
player->cfbgdata->SetRaceDisplayID();
}
}
```
(The dev didn't override, I did tho).

Reply
Reply
rektbyfaith
Administrator
Find
0
01-31-2023, 11:34 PM
#7
Archived author: Deleted User • Posted: 2023-01-31T23:34:55.378000+00:00
Original source

EDIT: Nevermind, the issue https://github.com/TrinityCore/TrinityCo.../issues/64 still happening. Will add it here if I find a fix.
Reply
Reply
rektbyfaith
01-31-2023, 11:34 PM #7

Archived author: Deleted User • Posted: 2023-01-31T23:34:55.378000+00:00
Original source

EDIT: Nevermind, the issue https://github.com/TrinityCore/TrinityCo.../issues/64 still happening. Will add it here if I find a fix.

Reply
Reply
rektbyfaith
Administrator
Find
0
02-01-2023, 12:02 AM
#8
Archived author: Deleted User • Posted: 2023-02-01T00:02:39.396000+00:00
Original source

Pretty sure it's this function `bool CFBGQueue::CFBGGroupInserter(BattlegroundQueue* queue, Battleground* bg, BattlegroundBracketId bracket_id, uint32 AllyFree, uint32 HordeFree, uint32 MinPlayers)` causing the bug. Will debug later
Reply
Reply
rektbyfaith
02-01-2023, 12:02 AM #8

Archived author: Deleted User • Posted: 2023-02-01T00:02:39.396000+00:00
Original source

Pretty sure it's this function `bool CFBGQueue::CFBGGroupInserter(BattlegroundQueue* queue, Battleground* bg, BattlegroundBracketId bracket_id, uint32 AllyFree, uint32 HordeFree, uint32 MinPlayers)` causing the bug. Will debug later

Reply
Reply
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)