[DiscordArchive] so it should be fine to just update the macro on the repo with this one?
[DiscordArchive] so it should be fine to just update the macro on the repo with this one?
Original source
so it should be fine to just update the macro on the repo with this one?
rektbyfaith
03-05-2023, 12:02 AM #1Archived author: Anchy • Posted: 2023-03-05T00:02:41.956000+00:00
Original source
so it should be fine to just update the macro on the repo with this one?
Original source
I reckon so, would obviously recommend testing it with different mysql versions first. With that macro being that old it also checks for mariadb < 10.4, so I'd definitely update that
rektbyfaith
03-05-2023, 12:03 AM #2Archived author: Foe • Posted: 2023-03-05T00:03:41.726000+00:00
Original source
I reckon so, would obviously recommend testing it with different mysql versions first. With that macro being that old it also checks for mariadb < 10.4, so I'd definitely update that
Original source
no just push it to production, yolo amirite?
rektbyfaith
03-05-2023, 12:04 AM #3Archived author: Anchy • Posted: 2023-03-05T00:04:03.579000+00:00
Original source
no just push it to production, yolo amirite?
Original source
set(_MySQL_mariadb_versions 10.2 10.3)
set(_MySQL_versions 5.0)
same with these
rektbyfaith
03-05-2023, 12:04 AM #4Archived author: Foe • Posted: 2023-03-05T00:04:06.416000+00:00
Original source
set(_MySQL_mariadb_versions 10.2 10.3)
set(_MySQL_versions 5.0)
same with these
Original source
but yeah, that macro is much more maintainable imo
rektbyfaith
03-05-2023, 12:04 AM #5Archived author: Foe • Posted: 2023-03-05T00:04:25.402000+00:00
Original source
but yeah, that macro is much more maintainable imo
Original source
adding 8.0 to that MySQL_versions list made it find 8.x just fine at least
rektbyfaith
03-05-2023, 12:06 AM #6Archived author: Foe • Posted: 2023-03-05T00:06:20.230000+00:00
Original source
adding 8.0 to that MySQL_versions list made it find 8.x just fine at least
Original source
I don't think I ever had an issue with it finding MySQL just MariaDB
rektbyfaith
03-05-2023, 12:07 AM #7Archived author: Anchy • Posted: 2023-03-05T00:07:45.795000+00:00
Original source
I don't think I ever had an issue with it finding MySQL just MariaDB
Original source
and it was just the include directory, it found the rest
rektbyfaith
03-05-2023, 12:08 AM #8Archived author: Anchy • Posted: 2023-03-05T00:08:03.123000+00:00
Original source
and it was just the include directory, it found the rest
Original source
yeah, the macro I linked hasn't been maintained by cmake and dropped from the latest release, so switching to that you still have to maintain versions yourself but it's hell of a lot cleaner
rektbyfaith
03-05-2023, 12:08 AM #9Archived author: Foe • Posted: 2023-03-05T00:08:50.563000+00:00
Original source
yeah, the macro I linked hasn't been maintained by cmake and dropped from the latest release, so switching to that you still have to maintain versions yourself but it's hell of a lot cleaner
Original source
I'll let somebody who knows what they are doing do a PR for that macro and maybe the OpenSSL one
rektbyfaith
03-05-2023, 12:09 AM #10Archived author: Anchy • Posted: 2023-03-05T00:09:57.070000+00:00
Original source
I'll let somebody who knows what they are doing do a PR for that macro and maybe the OpenSSL one
1 Guest(s)
1 Guest(s)