[DiscordArchive] Attempting to add the individual progression module to a fresh core build, I get the following fatal
[DiscordArchive] Attempting to add the individual progression module to a fresh core build, I get the following fatal
Original source
Attempting to add the individual progression module to a fresh core build, I get the following fatal error running `make -j`:
```cmake
/home/zimo/server/dev/modules/mod-individual-progression/src/IndividualProgressionPlayer.cpp:133:69: fatal error: non-virtual member function marked 'override' hides virtual member function
void OnGiveXP(Player* player, uint32& amount, Unit* /*victim*/) override
^
```
`make install` then fails with:
```cmake
[ 18%] Building CXX object modules/CMakeFiles/modules.dir/mod-individual-progression/src/IndividualProgressionPlayer.cpp.o
/home/zimo/server/dev/modules/mod-individual-progression/src/IndividualProgressionPlayer.cpp:133:69: fatal error: non-virtual member function marked 'override' hides virtual member function
void OnGiveXP(Player* player, uint32& amount, Unit* /*victim*/) override
^
/home/zimo/server/dev/src/server/game/Scripting/ScriptMgr.h:1038:18: note: hidden overloaded virtual function 'PlayerScript::OnGiveXP' declared here: different number of parameters (4 vs 3)
virtual void OnGiveXP(Player* /*player*/, uint32& /*amount*/, Unit* /*victim*/, uint8 /*xpSource*/) { }
^
1 error generated.
make[2]: *** [modules/CMakeFiles/modules.dir/build.make:118: modules/CMakeFiles/modules.dir/mod-individual-progression/src/IndividualProgressionPlayer.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1362: modules/CMakeFiles/modules.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
```
Can someone please help me or explain why is this happening?
rektbyfaith
05-15-2023, 02:28 AM #1Archived author: Zimo • Posted: 2023-05-15T02:28:35.838000+00:00
Original source
Attempting to add the individual progression module to a fresh core build, I get the following fatal error running `make -j`:
```cmake
/home/zimo/server/dev/modules/mod-individual-progression/src/IndividualProgressionPlayer.cpp:133:69: fatal error: non-virtual member function marked 'override' hides virtual member function
void OnGiveXP(Player* player, uint32& amount, Unit* /*victim*/) override
^
```
`make install` then fails with:
```cmake
[ 18%] Building CXX object modules/CMakeFiles/modules.dir/mod-individual-progression/src/IndividualProgressionPlayer.cpp.o
/home/zimo/server/dev/modules/mod-individual-progression/src/IndividualProgressionPlayer.cpp:133:69: fatal error: non-virtual member function marked 'override' hides virtual member function
void OnGiveXP(Player* player, uint32& amount, Unit* /*victim*/) override
^
/home/zimo/server/dev/src/server/game/Scripting/ScriptMgr.h:1038:18: note: hidden overloaded virtual function 'PlayerScript::OnGiveXP' declared here: different number of parameters (4 vs 3)
virtual void OnGiveXP(Player* /*player*/, uint32& /*amount*/, Unit* /*victim*/, uint8 /*xpSource*/) { }
^
1 error generated.
make[2]: *** [modules/CMakeFiles/modules.dir/build.make:118: modules/CMakeFiles/modules.dir/mod-individual-progression/src/IndividualProgressionPlayer.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1362: modules/CMakeFiles/modules.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
```
Can someone please help me or explain why is this happening?
Original source
<@375379987773259777> Remove the override on `void OnGiveXP` since that function is marked virtual.
rektbyfaith
05-15-2023, 02:41 AM #2Archived author: Meltie • Posted: 2023-05-15T02:41:42.575000+00:00
Original source
<@375379987773259777> Remove the override on `void OnGiveXP` since that function is marked virtual.
Original source
I already gone over the `IndividualProgressionPlayer.cpp` and didn't find it. Is it someplace else?
rektbyfaith
05-15-2023, 02:44 AM #3Archived author: Zimo • Posted: 2023-05-15T02:44:09.843000+00:00
Original source
I already gone over the `IndividualProgressionPlayer.cpp` and didn't find it. Is it someplace else?
Original source
Plus your missing a parameter in that same function. 4 vs 3
rektbyfaith
05-15-2023, 02:44 AM #4Archived author: Meltie • Posted: 2023-05-15T02:44:24.912000+00:00
Original source
Plus your missing a parameter in that same function. 4 vs 3
Original source
wrong file ♂️
rektbyfaith
05-15-2023, 02:45 AM #5Archived author: Zimo • Posted: 2023-05-15T02:45:11.142000+00:00
Original source
wrong file ♂️
Original source
<@375379987773259777> update the modules
rektbyfaith
05-15-2023, 02:45 AM #6Archived author: 0xCiBeR • Posted: 2023-05-15T02:45:51.713000+00:00
Original source
<@375379987773259777> update the modules
Original source
OnGiveXP has a new parameter
rektbyfaith
05-15-2023, 02:46 AM #7Archived author: 0xCiBeR • Posted: 2023-05-15T02:46:13.933000+00:00
Original source
OnGiveXP has a new parameter
Original source
This is the only module I have installed
rektbyfaith
05-15-2023, 02:47 AM #8Archived author: Zimo • Posted: 2023-05-15T02:47:03.816000+00:00
Original source
This is the only module I have installed
Original source
I'm sorry Meltie I'm quite new to this, what should I look for?
rektbyfaith
05-15-2023, 02:47 AM #9Archived author: Zimo • Posted: 2023-05-15T02:47:28.549000+00:00
Original source
I'm sorry Meltie I'm quite new to this, what should I look for?
Original source
See this PR: https://github.com/ZhengPeiRu21/mod-indi...n/pull/140
[Embed: fix: Include new parameter for OnGiveXP hook. by 0xCiBeR · Pull Req...]
Adds new parameter for OnGiveXP hook.
https://github.com/ZhengPeiRu21/mod-indi...n/pull/140
rektbyfaith
05-15-2023, 02:50 AM #10Archived author: 0xCiBeR • Posted: 2023-05-15T02:50:43.477000+00:00
Original source
See this PR: https://github.com/ZhengPeiRu21/mod-indi...n/pull/140
[Embed: fix: Include new parameter for OnGiveXP hook. by 0xCiBeR · Pull Req...]
Adds new parameter for OnGiveXP hook.
https://github.com/ZhengPeiRu21/mod-indi...n/pull/140
1 Guest(s)
1 Guest(s)