[DiscordArchive] how do i apply a "Ready For Review" label to my PR?
[DiscordArchive] how do i apply a "Ready For Review" label to my PR?
Original source
how do i apply a "Ready For Review" label to my PR?
rektbyfaith
01-18-2023, 09:14 PM #1Archived author: sh3rp • Posted: 2023-01-18T21:14:00.449000+00:00
Original source
how do i apply a "Ready For Review" label to my PR?
Original source
You don't
rektbyfaith
01-18-2023, 09:14 PM #2Archived author: Bench • Posted: 2023-01-18T21:14:40.571000+00:00
Original source
You don't
Original source
is there a group of folks that review the PRs then merge?
rektbyfaith
01-18-2023, 09:15 PM #3Archived author: sh3rp • Posted: 2023-01-18T21:15:12.296000+00:00
Original source
is there a group of folks that review the PRs then merge?
Original source
Well people go through and apply labels and some of those people also review the PR and then apply labels
rektbyfaith
01-18-2023, 09:16 PM #4Archived author: Bench • Posted: 2023-01-18T21:16:45.677000+00:00
Original source
Well people go through and apply labels and some of those people also review the PR and then apply labels
Original source
But most PRs need to be tested by another party to be merged as well
rektbyfaith
01-18-2023, 09:17 PM #5Archived author: Bench • Posted: 2023-01-18T21:17:02.974000+00:00
Original source
But most PRs need to be tested by another party to be merged as well
Original source
okay, no worries, just making sure i'm not missing any steps
rektbyfaith
01-18-2023, 09:17 PM #6Archived author: sh3rp • Posted: 2023-01-18T21:17:28.566000+00:00
Original source
okay, no worries, just making sure i'm not missing any steps
Original source
this is my first PR so i'd kinda like to avoid pissing off the people responsible for that kind of thing
rektbyfaith
01-18-2023, 09:18 PM #7Archived author: sh3rp • Posted: 2023-01-18T21:18:49.725000+00:00
Original source
this is my first PR so i'd kinda like to avoid pissing off the people responsible for that kind of thing
Original source
You're not gonna piss anyone off, don't worry
rektbyfaith
01-18-2023, 09:19 PM #8Archived author: Bench • Posted: 2023-01-18T21:19:23.805000+00:00
Original source
You're not gonna piss anyone off, don't worry
Original source
link the pr
rektbyfaith
01-18-2023, 09:22 PM #9Archived author: Kitzunu • Posted: 2023-01-18T21:22:06.403000+00:00
Original source
link the pr
Original source
https://github.com/azerothcore/azerothco...pull/14705
rektbyfaith
01-18-2023, 09:24 PM #10Archived author: Bench • Posted: 2023-01-18T21:24:52.666000+00:00
Original source
https://github.com/azerothcore/azerothco...pull/14705
1 Guest(s)
1 Guest(s)