Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] Would it be acceptable for me to move most of the hardcoded texts for the headless horseman to the D

[DiscordArchive] Would it be acceptable for me to move most of the hardcoded texts for the headless horseman to the D

[DiscordArchive] Would it be acceptable for me to move most of the hardcoded texts for the headless horseman to the D

rektbyfaith
Administrator
0
10-19-2022, 08:42 PM
#1
Archived author: Revision • Posted: 2022-10-19T20:42:19.764000+00:00
Original source

Would it be acceptable for me to move most of the hardcoded texts for the headless horseman to the DB along with the whole summoning him working or do I *really* have to create a separate PR for it?
rektbyfaith
10-19-2022, 08:42 PM #1

Archived author: Revision • Posted: 2022-10-19T20:42:19.764000+00:00
Original source

Would it be acceptable for me to move most of the hardcoded texts for the headless horseman to the DB along with the whole summoning him working or do I *really* have to create a separate PR for it?

rektbyfaith
Administrator
0
10-19-2022, 08:42 PM
#2
Archived author: Bench • Posted: 2022-10-19T20:42:21.202000+00:00
Original source

No
rektbyfaith
10-19-2022, 08:42 PM #2

Archived author: Bench • Posted: 2022-10-19T20:42:21.202000+00:00
Original source

No

rektbyfaith
Administrator
0
10-19-2022, 08:42 PM
#3
Archived author: Revision • Posted: 2022-10-19T20:42:24.199000+00:00
Original source

No
rektbyfaith
10-19-2022, 08:42 PM #3

Archived author: Revision • Posted: 2022-10-19T20:42:24.199000+00:00
Original source

No

rektbyfaith
Administrator
0
10-19-2022, 08:42 PM
#4
Archived author: Mons • Posted: 2022-10-19T20:42:25.921000+00:00
Original source

Thanks
rektbyfaith
10-19-2022, 08:42 PM #4

Archived author: Mons • Posted: 2022-10-19T20:42:25.921000+00:00
Original source

Thanks

rektbyfaith
Administrator
0
10-19-2022, 08:42 PM
#5
Archived author: Bench • Posted: 2022-10-19T20:42:48.920000+00:00
Original source

I think as long as both efforts work, you can do them in one PR
rektbyfaith
10-19-2022, 08:42 PM #5

Archived author: Bench • Posted: 2022-10-19T20:42:48.920000+00:00
Original source

I think as long as both efforts work, you can do them in one PR

rektbyfaith
Administrator
0
10-19-2022, 08:43 PM
#6
Archived author: Revision • Posted: 2022-10-19T20:43:47.660000+00:00
Original source

Sweet
rektbyfaith
10-19-2022, 08:43 PM #6

Archived author: Revision • Posted: 2022-10-19T20:43:47.660000+00:00
Original source

Sweet

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)