[DiscordArchive] That's with that module?
[DiscordArchive] That's with that module?
Original source
https://github.com/azerothcore/mod-learn-spells/pull/38
rektbyfaith
06-22-2022, 09:12 AM #11Archived author: Bench • Posted: 2022-06-22T09:12:06.280000+00:00
Original source
https://github.com/azerothcore/mod-learn-spells/pull/38
Original source
I know roughly 0 about github or pull requests
rektbyfaith
06-22-2022, 09:12 AM #12Archived author: Ben • Posted: 2022-06-22T09:12:09.364000+00:00
Original source
I know roughly 0 about github or pull requests
Original source
Does this mean it's only Dismiss, Feed, and Call still missing?
![[Image: unknown.png?ex=690c66a5&is=690b1525&hm=8...1da7fd355&]](https://cdn.discordapp.com/attachments/284406375495368704/989095693505413140/unknown.png?ex=690c66a5&is=690b1525&hm=880c2480f3aa245da02e292d448c03920271e85513823cd7e2e41da1da7fd355&)
rektbyfaith
06-22-2022, 09:13 AM #13Archived author: Ben • Posted: 2022-06-22T09:13:10.034000+00:00
Original source
Does this mean it's only Dismiss, Feed, and Call still missing?
Original source
![[Image: unknown.png?ex=690c66b5&is=690b1535&hm=0...c9d808f9b&]](https://cdn.discordapp.com/attachments/284406375495368704/989095760995950592/unknown.png?ex=690c66b5&is=690b1535&hm=0dd76c7a8078a40a7abc7ac65852bd2c49b7e9184d387c2c73013b7c9d808f9b&)
rektbyfaith
06-22-2022, 09:13 AM #14Archived author: Bench • Posted: 2022-06-22T09:13:26.105000+00:00
Original source
Original source
I noticed it after and added those,
rektbyfaith
06-22-2022, 09:13 AM #15Archived author: Roddan • Posted: 2022-06-22T09:13:27.788000+00:00
Original source
I noticed it after and added those,
Original source
One of the best ways to learn is to look at the files changed and try and learn how things work from there, commits rarely tell a whole story, unless their descriptions are quite descriptive
rektbyfaith
06-22-2022, 09:14 AM #16Archived author: Bench • Posted: 2022-06-22T09:14:05.237000+00:00
Original source
One of the best ways to learn is to look at the files changed and try and learn how things work from there, commits rarely tell a whole story, unless their descriptions are quite descriptive
Original source
And once again, since they're usually much lesser in scope, modules tend to be a better learning grounds for issues/PRs
rektbyfaith
06-22-2022, 09:18 AM #17Archived author: Bench • Posted: 2022-06-22T09:18:18.893000+00:00
Original source
And once again, since they're usually much lesser in scope, modules tend to be a better learning grounds for issues/PRs
Original source
Yeah some tend to be "simple" to understand a bit and edit
rektbyfaith
06-22-2022, 09:18 AM #18Archived author: Roddan • Posted: 2022-06-22T09:18:46.508000+00:00
Original source
Yeah some tend to be "simple" to understand a bit and edit
Original source
Maybe don't try and go throwing any PRs at the playerbots module, but issue reports never hurt and PRs aren't exactly frowned upon
rektbyfaith
06-22-2022, 09:19 AM #19Archived author: Bench • Posted: 2022-06-22T09:19:55.118000+00:00
Original source
Maybe don't try and go throwing any PRs at the playerbots module, but issue reports never hurt and PRs aren't exactly frowned upon