[DiscordArchive] To which event?
[DiscordArchive] To which event?
Original source
That sounds like a decent approach if you control each and every Lua script. I don't see that ending well with code from multiple independent scripts though
rektbyfaith
05-09-2023, 01:57 PM #11Archived author: Honey • Posted: 2023-05-09T13:57:20.850000+00:00
Original source
That sounds like a decent approach if you control each and every Lua script. I don't see that ending well with code from multiple independent scripts though
Original source
You'd obviously have a return function per script, registered the same way as any other event registry
rektbyfaith
05-09-2023, 02:11 PM #12Archived author: Foe • Posted: 2023-05-09T14:11:04.112000+00:00
Original source
You'd obviously have a return function per script, registered the same way as any other event registry
Original source
In essence it's the same thing as what you have now, but you'd do the registry of the return function on load and not define specific return functions on async query calls
rektbyfaith
05-09-2023, 02:11 PM #13Archived author: Foe • Posted: 2023-05-09T14:11:55.672000+00:00
Original source
In essence it's the same thing as what you have now, but you'd do the registry of the return function on load and not define specific return functions on async query calls
Original source
All in all it's a massive performance improvement either way, especially when you start dealing with large queries and datasets. The main difference is how you deal with other logic that expects the data to be in place immediately
rektbyfaith
05-09-2023, 02:19 PM #14Archived author: Foe • Posted: 2023-05-09T14:19:10.973000+00:00
Original source
All in all it's a massive performance improvement either way, especially when you start dealing with large queries and datasets. The main difference is how you deal with other logic that expects the data to be in place immediately
Original source
Most of the usage would be to load player related data at login. If the player manages to call a function which finds no data, a nil check prevents proceeding.
Try again in 2 seconds.
rektbyfaith
05-09-2023, 02:34 PM #15Archived author: Honey • Posted: 2023-05-09T14:34:40.286000+00:00
Original source
Most of the usage would be to load player related data at login. If the player manages to call a function which finds no data, a nil check prevents proceeding.
Try again in 2 seconds.
Original source
I can't judge the difference between a function per callback or one function handling all callbacks. Leaving that aside,it just seems like extra steps.
rektbyfaith
05-09-2023, 02:36 PM #16Archived author: Honey • Posted: 2023-05-09T14:36:05.531000+00:00
Original source
I can't judge the difference between a function per callback or one function handling all callbacks. Leaving that aside,it just seems like extra steps.
Original source
It's a preference thing really, I personally think it's cleaner to have one function that deals with one "function", not multiple functions dealing with, in essence, the same thing
rektbyfaith
05-09-2023, 02:48 PM #17Archived author: Foe • Posted: 2023-05-09T14:48:56.478000+00:00
Original source
It's a preference thing really, I personally think it's cleaner to have one function that deals with one "function", not multiple functions dealing with, in essence, the same thing
Original source
Eluna::GEluna
Instead of this, you should use sEluna btw
rektbyfaith
05-09-2023, 03:37 PM #18Archived author: Foe • Posted: 2023-05-09T15:37:59.433000+00:00
Original source
Eluna::GEluna
Instead of this, you should use sEluna btw
Original source
That said, I'd probably move the whole template function into the ElunaQuery class
rektbyfaith
05-09-2023, 03:38 PM #19Archived author: Foe • Posted: 2023-05-09T15:38:19.949000+00:00
Original source
That said, I'd probably move the whole template function into the ElunaQuery class
Original source
Good catch, thanks!
rektbyfaith
05-09-2023, 03:45 PM #20Archived author: Roboto • Posted: 2023-05-09T15:45:11.552000+00:00
Original source
Good catch, thanks!
1 Guest(s)
1 Guest(s)