[DiscordArchive] The question here stands though, if I (or someone) wants to implement new functionality to Eluna, ho
[DiscordArchive] The question here stands though, if I (or someone) wants to implement new functionality to Eluna, ho
Original source
yeah i really think this should be implemented sooner rather than later
rektbyfaith
01-07-2022, 03:52 PM #11Archived author: kebabstorm • Posted: 2022-01-07T15:52:39.317000+00:00
Original source
yeah i really think this should be implemented sooner rather than later
Original source
Hi kebabstorm, i remember your PR. Glad to have you here.
rektbyfaith
01-07-2022, 03:53 PM #12Archived author: Honey • Posted: 2022-01-07T15:53:23.187000+00:00
Original source
Hi kebabstorm, i remember your PR. Glad to have you here.
Original source
and even just as a rookie diving into this, I already think that Eluna and LUA is the right way going forward. I think AzerothCores modular approach to adding stuff outside the core is great, but Eluna is even better, miles better
rektbyfaith
01-07-2022, 03:53 PM #13Archived author: kebabstorm • Posted: 2022-01-07T15:53:33.635000+00:00
Original source
and even just as a rookie diving into this, I already think that Eluna and LUA is the right way going forward. I think AzerothCores modular approach to adding stuff outside the core is great, but Eluna is even better, miles better
Original source
> As another way would be to have the function but have it not return anything in other cores.
Hmm I'm not sure, I guess it could be misleading for other core users. You might wonder why your query returns nothing, but if you have an error message saying that the function doesn't exist it's clearer
But honestly Rochet2 is probably the person to ask here
rektbyfaith
01-07-2022, 03:54 PM #14Archived author: Roboto • Posted: 2022-01-07T15:54:22.385000+00:00
Original source
> As another way would be to have the function but have it not return anything in other cores.
Hmm I'm not sure, I guess it could be misleading for other core users. You might wonder why your query returns nothing, but if you have an error message saying that the function doesn't exist it's clearer
But honestly Rochet2 is probably the person to ask here
Original source
it is already in a state where most of the stuff people do with custom npcs and so in c++ modules can be done purely in eluna. only thing to do is expose more functions from the core and add some necessary functionality to make it even more flexible. I sincerely believe that would also add a lot of contributors like you see in the wow client addon development scene, C++ can be daunting even to people who have mastered lua
rektbyfaith
01-07-2022, 03:56 PM #15Archived author: kebabstorm • Posted: 2022-01-07T15:56:26.390000+00:00
Original source
it is already in a state where most of the stuff people do with custom npcs and so in c++ modules can be done purely in eluna. only thing to do is expose more functions from the core and add some necessary functionality to make it even more flexible. I sincerely believe that would also add a lot of contributors like you see in the wow client addon development scene, C++ can be daunting even to people who have mastered lua
Original source
Okay , thanks . So rochet2 is the main creator of Eluna , right?
rektbyfaith
01-07-2022, 03:57 PM #16Archived author: kebabstorm • Posted: 2022-01-07T15:57:19.973000+00:00
Original source
Okay , thanks . So rochet2 is the main creator of Eluna , right?
Original source
Not sure who originally created it but he's the one maintaining it now
rektbyfaith
01-07-2022, 03:57 PM #17Archived author: Roboto • Posted: 2022-01-07T15:57:43.969000+00:00
Original source
Not sure who originally created it but he's the one maintaining it now
Original source
okay , hope he sees this. as my next question is about the documentation. I absolutely love this api doc eluna has https://elunaluaengine.github.io/ , it makes starting development for any newbie super easy. when adding new functionality the funcs should be then added to the docs too, but I haven't currently stumbled upon any functions in the doc which would say "this func currently works only in core X and Y". so I would like to know how to do this documentation and where to do the actual PR's . is it https://github.com/ElunaLuaEngine/ElunaL....github.io for the docs? how about the core itself, do I make the PR to https://github.com/azerothcore/Eluna or https://github.com/ElunaLuaEngine/Eluna
rektbyfaith
01-07-2022, 04:02 PM #18Archived author: kebabstorm • Posted: 2022-01-07T16:02:33.136000+00:00
Original source
okay , hope he sees this. as my next question is about the documentation. I absolutely love this api doc eluna has https://elunaluaengine.github.io/ , it makes starting development for any newbie super easy. when adding new functionality the funcs should be then added to the docs too, but I haven't currently stumbled upon any functions in the doc which would say "this func currently works only in core X and Y". so I would like to know how to do this documentation and where to do the actual PR's . is it https://github.com/ElunaLuaEngine/ElunaL....github.io for the docs? how about the core itself, do I make the PR to https://github.com/azerothcore/Eluna or https://github.com/ElunaLuaEngine/Eluna
Original source
The docs are automatically generated from the code's doc comments iirc so I don't think you can PR that. Rochet probably updates the website from time to time
rektbyfaith
01-07-2022, 04:04 PM #19Archived author: Roboto • Posted: 2022-01-07T16:04:43.087000+00:00
Original source
The docs are automatically generated from the code's doc comments iirc so I don't think you can PR that. Rochet probably updates the website from time to time
Original source
> do I make the PR to https://github.com/azerothcore/Eluna or https://github.com/ElunaLuaEngine/Eluna
If you want your change to work with AC, pick our work. For the other cores, it's the master repo probably.
rektbyfaith
01-07-2022, 04:07 PM #20Archived author: Honey • Posted: 2022-01-07T16:07:15.380000+00:00
Original source
> do I make the PR to https://github.com/azerothcore/Eluna or https://github.com/ElunaLuaEngine/Eluna
If you want your change to work with AC, pick our work. For the other cores, it's the master repo probably.
1 Guest(s)
1 Guest(s)