[DiscordArchive] Should we enable this?
[DiscordArchive] Should we enable this?
Archived author: Ouizzy • Posted: 2019-03-24T22:32:19.303000+00:00
Original source
Should we enable this?
Archived author: Nix • Posted: 2019-03-24T22:33:03.125000+00:00
Original source
There isn't really a lot of downside to it, it only does something if there is a subscriber (listening to the event)
Archived author: Nix • Posted: 2019-03-24T22:33:52.315000+00:00
Original source
Sure, if you only write scripts that do stuff on player cast it might be a bit heavy, but that would be an issue that would have to be tackled on another level
Archived author: Ouizzy • Posted: 2019-03-24T22:36:34.121000+00:00
Original source
so
Archived author: Ouizzy • Posted: 2019-03-24T22:36:37.770000+00:00
Original source
shouldn't i have a case
Archived author: Ouizzy • Posted: 2019-03-24T22:36:40.462000+00:00
Original source
#ifdef ELUNA
Archived author: Ouizzy • Posted: 2019-03-24T22:36:56.329000+00:00
Original source
to make it for eluna only?
Archived author: Nix • Posted: 2019-03-24T22:37:37.542000+00:00
Original source
Well not entirely
Archived author: Nix • Posted: 2019-03-24T22:38:00.053000+00:00
Original source
You would have to replace that line with the sEluna call to trigger the event
Archived author: Nix • Posted: 2019-03-24T22:38:51.324000+00:00
Original source
From
```
//sScriptMgr->OnPlayerSpellCast(playerCaster, this, skipCheck); // pussywizard: optimization
```
To
```
#ifdef ELUNA
sEluna->OnSpellCast(player, spell, skipCheck);
#endif
```