[DiscordArchive] Hey guys, I would like your opinion on this, for several reasons, I would like to be able to telepor
[DiscordArchive] Hey guys, I would like your opinion on this, for several reasons, I would like to be able to telepor
Original source
Hey guys, I would like your opinion on this, for several reasons, I would like to be able to teleport players in my instance as GM. Actually there is an option which allows to do this `CONFIG_INSTANCE_GMSUMMON_PLAYER` (which does not apply when teleporting a group via `.groupsummon` which seems weird, but nvm...).
But you also have to be the raid leader (which seems weird for a GM):
```cpp
// we are in instance, and can summon only player in our group with us as lead
if (toInstance && (
!handler->GetSession()->GetPlayer()->GetGroup() || (group->GetLeaderGUID() != handler->GetSession()->GetPlayer()->GetGUID()) ||
(handler->GetSession()->GetPlayer()->GetGroup()->GetLeaderGUID() != handler->GetSession()->GetPlayer()->GetGUID())))
// the last check is a bit excessive, but let it be, just in case
{
handler->SendSysMessage(LANG_CANNOT_SUMMON_TO_INST);
handler->SetSentErrorMessage(true);
return false;
}
```
I would like to do a PR which will simply remove this condition for summon and groupsummon, because I see no reason for this. Also, even when you remove this, there are still verification that a player can be teleported to that specific map/instance id.
Do you think I missed something here?
rektbyfaith
01-15-2023, 05:37 PM #1Archived author: Sky • Posted: 2023-01-15T17:37:41.387000+00:00
Original source
Hey guys, I would like your opinion on this, for several reasons, I would like to be able to teleport players in my instance as GM. Actually there is an option which allows to do this `CONFIG_INSTANCE_GMSUMMON_PLAYER` (which does not apply when teleporting a group via `.groupsummon` which seems weird, but nvm...).
But you also have to be the raid leader (which seems weird for a GM):
```cpp
// we are in instance, and can summon only player in our group with us as lead
if (toInstance && (
!handler->GetSession()->GetPlayer()->GetGroup() || (group->GetLeaderGUID() != handler->GetSession()->GetPlayer()->GetGUID()) ||
(handler->GetSession()->GetPlayer()->GetGroup()->GetLeaderGUID() != handler->GetSession()->GetPlayer()->GetGUID())))
// the last check is a bit excessive, but let it be, just in case
{
handler->SendSysMessage(LANG_CANNOT_SUMMON_TO_INST);
handler->SetSentErrorMessage(true);
return false;
}
```
I would like to do a PR which will simply remove this condition for summon and groupsummon, because I see no reason for this. Also, even when you remove this, there are still verification that a player can be teleported to that specific map/instance id.
Do you think I missed something here?
1 Guest(s)
1 Guest(s)