[DiscordArchive] <@203326888888893440> I've implemented it on my own server, and so I would probably consider a PR in
[DiscordArchive] <@203326888888893440> I've implemented it on my own server, and so I would probably consider a PR in
Original source
<@203326888888893440> I've implemented it on my own server, and so I would probably consider a PR instead. But what I was curious was, this sort of takes away a level of customization that you might have if you already have configured these values (for example, not all folks are running stock, some may want to enhance the curve a little bit, or perhaps make it more difficult..) How important is it that we preserve the functionality of, say, `SkillChance.Yellow` or `SkillChance.Green` if they don't really fit with a change like this?
rektbyfaith
09-27-2022, 08:05 PM #1Archived author: Saxxon • Posted: 2022-09-27T20:05:02.650000+00:00
Original source
<@203326888888893440> I've implemented it on my own server, and so I would probably consider a PR instead. But what I was curious was, this sort of takes away a level of customization that you might have if you already have configured these values (for example, not all folks are running stock, some may want to enhance the curve a little bit, or perhaps make it more difficult..) How important is it that we preserve the functionality of, say, `SkillChance.Yellow` or `SkillChance.Green` if they don't really fit with a change like this?
Original source
My input is that more config option are always nice, or a hook if it is not something convenient to change through a config option, but most important is that the default values and behavior should be accurate to 3.3.5 so that it is accurately preserved.
rektbyfaith
09-27-2022, 08:06 PM #2Archived author: 郑佩茹 • Posted: 2022-09-27T20:06:11.864000+00:00
Original source
My input is that more config option are always nice, or a hook if it is not something convenient to change through a config option, but most important is that the default values and behavior should be accurate to 3.3.5 so that it is accurately preserved.
Original source
So if fixing it breaks some existing config and it is not possible to make the config work, then it is still better to fix.
rektbyfaith
09-27-2022, 08:06 PM #3Archived author: 郑佩茹 • Posted: 2022-09-27T20:06:38.144000+00:00
Original source
So if fixing it breaks some existing config and it is not possible to make the config work, then it is still better to fix.
Original source
Yea, I'm in agreement with ZhengPeiRu
rektbyfaith
09-27-2022, 08:07 PM #4Archived author: Bench • Posted: 2022-09-27T20:07:08.348000+00:00
Original source
Yea, I'm in agreement with ZhengPeiRu
Original source
If nothing else, it'll leave a trail on Github which is very helpful
rektbyfaith
09-27-2022, 08:07 PM #5Archived author: Bench • Posted: 2022-09-27T20:07:27.377000+00:00
Original source
If nothing else, it'll leave a trail on Github which is very helpful
Original source
Thanks for your guidance I'll put in the PR today then, once I have done a quick review of the isolated changes.
rektbyfaith
09-27-2022, 08:09 PM #6Archived author: Saxxon • Posted: 2022-09-27T20:09:14.748000+00:00
Original source
Thanks for your guidance I'll put in the PR today then, once I have done a quick review of the isolated changes.
1 Guest(s)
1 Guest(s)