[DiscordArchive] Greetings, the question arose when you additionally give the player talent points, why do they disap
[DiscordArchive] Greetings, the question arose when you additionally give the player talent points, why do they disap
Original source
Greetings, the question arose when you additionally give the player talent points, why do they disappear after the relog? Is there an option to fix it somehow?
rektbyfaith
09-08-2022, 04:43 PM #1Archived author: Frostik • Posted: 2022-09-08T16:43:23.482000+00:00
Original source
Greetings, the question arose when you additionally give the player talent points, why do they disappear after the relog? Is there an option to fix it somehow?
Original source
on login there is check verifying talent count
rektbyfaith
09-08-2022, 04:53 PM #2Archived author: Rymercyble • Posted: 2022-09-08T16:53:47.885000+00:00
Original source
on login there is check verifying talent count
Original source
u can change it in code but if u did not modify ur core yet and u do it from that point u run modified core which needs caution during updates
rektbyfaith
09-08-2022, 04:54 PM #3Archived author: Rymercyble • Posted: 2022-09-08T16:54:50.573000+00:00
Original source
u can change it in code but if u did not modify ur core yet and u do it from that point u run modified core which needs caution during updates
Original source
https://github.com/azerothcore/azerothco...cpp#L13289
rektbyfaith
09-08-2022, 04:59 PM #4Archived author: Rymercyble • Posted: 2022-09-08T16:59:05.974000+00:00
Original source
https://github.com/azerothcore/azerothco...cpp#L13289
Original source
Yeah, or you can just create a fork and merge new updates into that fork and preserve your updates. The only time you have to think about it is if an update causes a conflict at which point all you have to do is resolve it which is usually very simple.
rektbyfaith
09-08-2022, 05:02 PM #5Archived author: Revision • Posted: 2022-09-08T17:02:39.200000+00:00
Original source
Yeah, or you can just create a fork and merge new updates into that fork and preserve your updates. The only time you have to think about it is if an update causes a conflict at which point all you have to do is resolve it which is usually very simple.
Original source
its not only conflict there could be side effect above or under ur change
rektbyfaith
09-08-2022, 05:03 PM #6Archived author: Rymercyble • Posted: 2022-09-08T17:03:30.128000+00:00
Original source
its not only conflict there could be side effect above or under ur change
Original source
You're being way too negative.
rektbyfaith
09-08-2022, 05:04 PM #7Archived author: Revision • Posted: 2022-09-08T17:04:05.744000+00:00
Original source
You're being way too negative.
Original source
its realism
rektbyfaith
09-08-2022, 05:24 PM #8Archived author: Rymercyble • Posted: 2022-09-08T17:24:13.607000+00:00
Original source
its realism
Original source
That is what I have been doing on my server- fork the repo, create a new branch on it, and deploy directly from that branch.. makes it easy to keep incoming changes intact, my custom changes separate, and also easy to cherrypick my own fixes into PRs to feed back upstream
rektbyfaith
09-08-2022, 05:27 PM #9Archived author: Saxxon • Posted: 2022-09-08T17:27:15.143000+00:00
Original source
That is what I have been doing on my server- fork the repo, create a new branch on it, and deploy directly from that branch.. makes it easy to keep incoming changes intact, my custom changes separate, and also easy to cherrypick my own fixes into PRs to feed back upstream
Original source
Sorta have to expect that any custom changes will have side effects, that is acceptable risk and part of doing all this in the first place ;D
rektbyfaith
09-08-2022, 05:29 PM #10Archived author: Saxxon • Posted: 2022-09-08T17:29:16.958000+00:00
Original source
Sorta have to expect that any custom changes will have side effects, that is acceptable risk and part of doing all this in the first place ;D
1 Guest(s)
1 Guest(s)