[DiscordArchive] are you adding a container with key value pairs that point to the DB?
[DiscordArchive] are you adding a container with key value pairs that point to the DB?
Original source
yeh look like a lot of magic numbers in these files. I don't build scripts at all so haven't even seen
rektbyfaith
03-15-2022, 01:01 AM #11Archived author: Dep • Posted: 2022-03-15T01:01:52.499000+00:00
Original source
yeh look like a lot of magic numbers in these files. I don't build scripts at all so haven't even seen
Original source
Sometime I meet wrong usage of `#define` at enum - values for MenuID were assigned as MenuItem, while there can be several MenuItems in one MenuID
rektbyfaith
03-15-2022, 01:05 AM #12Archived author: Bogir • Posted: 2022-03-15T01:05:46.235000+00:00
Original source
Sometime I meet wrong usage of `#define` at enum - values for MenuID were assigned as MenuItem, while there can be several MenuItems in one MenuID
Original source
```cpp
constexpr std::pair<uint32, uint32> gossip_bear1 = { 3882, 0 }; // What do you represent, spirit? =>3881
constexpr std::pair<uint32, uint32> gossip_bear2 = { 3881, 0 }; // I seek to understand the importance of strength of the body =>3883
constexpr std::pair<uint32, uint32> gossip_bear3 = { 3883, 0 }; // I seek to understand the importance of strength of the heart =>3884
constexpr std::pair<uint32, uint32> gossip_bear4 = { 3884, 0 }; // I have heard your words, Great Bear Spirit, and I understand. ... =>3885
```
rektbyfaith
03-15-2022, 01:06 AM #13Archived author: Dep • Posted: 2022-03-15T01:06:35.385000+00:00
Original source
```cpp
constexpr std::pair<uint32, uint32> gossip_bear1 = { 3882, 0 }; // What do you represent, spirit? =>3881
constexpr std::pair<uint32, uint32> gossip_bear2 = { 3881, 0 }; // I seek to understand the importance of strength of the body =>3883
constexpr std::pair<uint32, uint32> gossip_bear3 = { 3883, 0 }; // I seek to understand the importance of strength of the heart =>3884
constexpr std::pair<uint32, uint32> gossip_bear4 = { 3884, 0 }; // I have heard your words, Great Bear Spirit, and I understand. ... =>3885
```
Original source
is the missmatching comment on purpose in this?
rektbyfaith
03-15-2022, 01:06 AM #14Archived author: Dep • Posted: 2022-03-15T01:06:42.545000+00:00
Original source
is the missmatching comment on purpose in this?
Original source
references different ID
rektbyfaith
03-15-2022, 01:06 AM #15Archived author: Dep • Posted: 2022-03-15T01:06:53.285000+00:00
Original source
references different ID
Original source
I have to say I don't like this `case GOSSIP_ACTION_INFO_DEF + 3:` system that's going on in this file
rektbyfaith
03-15-2022, 01:07 AM #16Archived author: Dep • Posted: 2022-03-15T01:07:32.164000+00:00
Original source
I have to say I don't like this `case GOSSIP_ACTION_INFO_DEF + 3:` system that's going on in this file
Original source
but then again it's just scripts
rektbyfaith
03-15-2022, 01:08 AM #17Archived author: Dep • Posted: 2022-03-15T01:08:22.044000+00:00
Original source
but then again it's just scripts
Original source
You mean why variable called `gossip_bear1` ?
Someone decided to call it that a long time ago, maybe because the action comes from the bear. I don't know
rektbyfaith
03-15-2022, 01:20 AM #18Archived author: Bogir • Posted: 2022-03-15T01:20:46.755000+00:00
Original source
You mean why variable called `gossip_bear1` ?
Someone decided to call it that a long time ago, maybe because the action comes from the bear. I don't know
Original source
`{ 3882, 0 }; // =>3881`
rektbyfaith
03-15-2022, 01:21 AM #19Archived author: Dep • Posted: 2022-03-15T01:21:19.639000+00:00
Original source
`{ 3882, 0 }; // =>3881`
Original source
this is what I mean
rektbyfaith
03-15-2022, 01:21 AM #20Archived author: Dep • Posted: 2022-03-15T01:21:22.516000+00:00
Original source
this is what I mean
1 Guest(s)
1 Guest(s)