[DiscordArchive] <@!109652764488892416> did you suggest nodiscard because of ```if (!creature->isVendorWithIconSpeak(
[DiscordArchive] <@!109652764488892416> did you suggest nodiscard because of ```if (!creature->isVendorWithIconSpeak(
Original source
as usual, great
rektbyfaith
06-10-2021, 03:10 PM #11Archived author: Claudiodfc • Posted: 2021-06-10T15:10:58.099000+00:00
Original source
as usual, great
Original source
```
enum class HighGuid
{
Item = 0x4000, // blizz 4000
Container = 0x4000, // blizz 4000
Player = 0x0000, // blizz 0000
GameObject = 0xF110, // blizz F110
Transport = 0xF120, // blizz F120 (for GAMEOBJECT_TYPE_TRANSPORT)
Unit = 0xF130, // blizz F130
Pet = 0xF140, // blizz F140
Vehicle = 0xF150, // blizz F550
DynamicObject = 0xF100, // blizz F100
Corpse = 0xF101, // blizz F100
Mo_Transport = 0x1FC0, // blizz 1FC0 (for GAMEOBJECT_TYPE_MO_TRANSPORT)
Instance = 0x1F40, // blizz 1F40
Group = 0x1F50,
};
```
rektbyfaith
06-10-2021, 03:14 PM #12Archived author: Claudiodfc • Posted: 2021-06-10T15:14:51.719000+00:00
Original source
```
enum class HighGuid
{
Item = 0x4000, // blizz 4000
Container = 0x4000, // blizz 4000
Player = 0x0000, // blizz 0000
GameObject = 0xF110, // blizz F110
Transport = 0xF120, // blizz F120 (for GAMEOBJECT_TYPE_TRANSPORT)
Unit = 0xF130, // blizz F130
Pet = 0xF140, // blizz F140
Vehicle = 0xF150, // blizz F550
DynamicObject = 0xF100, // blizz F100
Corpse = 0xF101, // blizz F100
Mo_Transport = 0x1FC0, // blizz 1FC0 (for GAMEOBJECT_TYPE_MO_TRANSPORT)
Instance = 0x1F40, // blizz 1F40
Group = 0x1F50,
};
```
Original source
what does this class mean? what's a HighGUID?
rektbyfaith
06-10-2021, 03:14 PM #13Archived author: Claudiodfc • Posted: 2021-06-10T15:14:59.472000+00:00
Original source
what does this class mean? what's a HighGUID?
Original source
and why is this type defined like this? why not simply use the std type? ```
typedef uint32 LowType;
```
rektbyfaith
06-10-2021, 03:16 PM #14Archived author: Claudiodfc • Posted: 2021-06-10T15:16:28.031000+00:00
Original source
and why is this type defined like this? why not simply use the std type? ```
typedef uint32 LowType;
```
Original source
honestly I don't think I can fix anything else anymore using this ObjectGuid class, it makes no sense to me and without a single comment even worse
rektbyfaith
06-10-2021, 03:18 PM #15Archived author: Claudiodfc • Posted: 2021-06-10T15:18:19.863000+00:00
Original source
honestly I don't think I can fix anything else anymore using this ObjectGuid class, it makes no sense to me and without a single comment even worse
Original source
this should have never been merged imho
rektbyfaith
06-10-2021, 03:18 PM #16Archived author: Claudiodfc • Posted: 2021-06-10T15:18:35.980000+00:00
Original source
this should have never been merged imho
Original source
Low guid equals the DB entry. E.g. the id in the `creature` table. Highguid is unique across all maps and objects
rektbyfaith
06-10-2021, 03:19 PM #17Archived author: Honey • Posted: 2021-06-10T15:19:10.640000+00:00
Original source
Low guid equals the DB entry. E.g. the id in the `creature` table. Highguid is unique across all maps and objects
Original source
that i did remember but then look at this
rektbyfaith
06-10-2021, 03:19 PM #18Archived author: Claudiodfc • Posted: 2021-06-10T15:19:37.066000+00:00
Original source
that i did remember but then look at this
Original source
```
LowType GetCounter() const
{
return HasEntry()
? LowType(_guid & UI64LIT(0x0000000000FFFFFF))
: LowType(_guid & UI64LIT(0x00000000FFFFFFFF));
}
```
rektbyfaith
06-10-2021, 03:20 PM #19Archived author: Claudiodfc • Posted: 2021-06-10T15:20:08.846000+00:00
Original source
```
LowType GetCounter() const
{
return HasEntry()
? LowType(_guid & UI64LIT(0x0000000000FFFFFF))
: LowType(_guid & UI64LIT(0x00000000FFFFFFFF));
}
```
Original source
get counter doesn't make sense, what is a counter or what does it even mean, I guess we are getting the LowGUID?
rektbyfaith
06-10-2021, 03:20 PM #20Archived author: Claudiodfc • Posted: 2021-06-10T15:20:28.372000+00:00
Original source
get counter doesn't make sense, what is a counter or what does it even mean, I guess we are getting the LowGUID?