[DiscordArchive] Is it just me or is the World-DB table spell_custom_attr (http://www.azerothcore.org/wiki/spell_cust
[DiscordArchive] Is it just me or is the World-DB table spell_custom_attr (http://www.azerothcore.org/wiki/spell_cust
Original source
Is it just me or is the World-DB table spell_custom_attr (http://www.azerothcore.org/wiki/spell_custom_attr) completely unused? I don't see any references to it in the core. Rather it seems the data this table should provide is instead hardcoded in C++ in for example SpellMgr.cpp:2866. Or am I missing something here?
rektbyfaith
05-28-2020, 12:28 PM #1Archived author: MaloW • Posted: 2020-05-28T12:28:44.158000+00:00
Original source
Is it just me or is the World-DB table spell_custom_attr (http://www.azerothcore.org/wiki/spell_custom_attr) completely unused? I don't see any references to it in the core. Rather it seems the data this table should provide is instead hardcoded in C++ in for example SpellMgr.cpp:2866. Or am I missing something here?
Original source
It should not be hardcoded
https://github.com/azerothcore/azerothco.../pull/3056 is a great example of an attempt of making it into the DBs
[Embed: fix(Core/Spell): Implement SPELL_ATTR0_CU_DONT_BREAK_STEALTH by gen...]
Soulshatter doesn't remove stealth
Before we had a bunch of spells that were hardcoded to not break stealth. Using the PR from trinitycore I added the missing spells that were not suppose...
https://github.com/azerothcore/azerothco.../pull/3056
rektbyfaith
05-28-2020, 12:32 PM #2Archived author: Kitzunu • Posted: 2020-05-28T12:32:10.527000+00:00
Original source
It should not be hardcoded
https://github.com/azerothcore/azerothco.../pull/3056 is a great example of an attempt of making it into the DBs
[Embed: fix(Core/Spell): Implement SPELL_ATTR0_CU_DONT_BREAK_STEALTH by gen...]
Soulshatter doesn't remove stealth
Before we had a bunch of spells that were hardcoded to not break stealth. Using the PR from trinitycore I added the missing spells that were not suppose...
https://github.com/azerothcore/azerothco.../pull/3056
Original source
Ah yes, looks like that PR is actually adding loading of the spell_custom_attr table so that it's actually used. Nice
rektbyfaith
05-28-2020, 12:34 PM #3Archived author: MaloW • Posted: 2020-05-28T12:34:32.990000+00:00
Original source
Ah yes, looks like that PR is actually adding loading of the spell_custom_attr table so that it's actually used. Nice
Original source
<@107869937443307520> nah not a custom channel, I hackfixed it
rektbyfaith
05-28-2020, 02:39 PM #4Archived author: Chaz • Posted: 2020-05-28T14:39:06.509000+00:00
Original source
<@107869937443307520> nah not a custom channel, I hackfixed it
Original source
<@!207901137267851264> there is a "/" command for it something like /channel announce off
rektbyfaith
05-28-2020, 03:11 PM #5Archived author: Kitzunu • Posted: 2020-05-28T15:11:42.374000+00:00
Original source
<@!207901137267851264> there is a "/" command for it something like /channel announce off
Original source
ye doesnt save on reboot, i hackfixed it by commenting out SendToAll in channel.cpp
rektbyfaith
05-28-2020, 03:42 PM #6Archived author: Chaz • Posted: 2020-05-28T15:42:40.895000+00:00
Original source
ye doesnt save on reboot, i hackfixed it by commenting out SendToAll in channel.cpp